Fix the problem that some stacked panels might not be brought to the top when a collapsed panel is …

chrome/browser/ui/gtk/panels/panel_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/panels/panel_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
@@ skipping 177 matching lines @@
 gfx::Size& GetFrameSize() {
   CR_DEFINE_STATIC_LOCAL(gfx::Size, frame_size, ());
   return frame_size;
 }
 
 void SetFrameSize(const gfx::Size& new_size) {
   gfx::Size& frame_size = GetFrameSize();
   frame_size.SetSize(new_size.width(), new_size.height());
 }
 
-}
+}  // namespace
 
 // static
 NativePanel* Panel::CreateNativePanel(Panel* panel,
                                       const gfx::Rect& bounds,
                                       bool always_on_top) {
   PanelGtk* panel_gtk = new PanelGtk(panel, bounds, always_on_top);
   panel_gtk->Init();
   return panel_gtk;
 }
 
@@ skipping 392 matching lines @@
                    FALSE, FALSE, 0);
 }
 
 gboolean PanelGtk::OnTitlebarButtonPressEvent(
     GtkWidget* widget, GdkEventButton* event) {
   if (event->button != 1)
     return TRUE;
   if (event->type != GDK_BUTTON_PRESS)
     return TRUE;
 
-  gdk_window_raise(gtk_widget_get_window(GTK_WIDGET(window_)));
+  // If the panel is in a stack, bring all other panels in the stack to the
+  // top.
+  StackedPanelCollection* stack = panel_->stack();
+  if (stack) {
+    for (StackedPanelCollection::Panels::const_iterator iter =
+             stack->panels().begin();
+         iter != stack->panels().end(); ++iter) {
+      gdk_window_raise(gtk_widget_get_window(GTK_WIDGET(
+          (*iter)->GetNativeWindow())));
+    }
+  } else {
+    gdk_window_raise(gtk_widget_get_window(GTK_WIDGET(window_)));
+  }
+
   EnsureDragHelperCreated();
   drag_helper_->InitialTitlebarMousePress(event, titlebar_->widget());
   return TRUE;
 }
 
 gboolean PanelGtk::OnTitlebarButtonReleaseEvent(
     GtkWidget* widget, GdkEventButton* event) {
   if (event->button != 1)
     return TRUE;
 
@@ skipping 235 matching lines @@
   // No way to deactive a GTK window. Pretend panel is deactivated
   // and ignore input.
   ActiveWindowChanged(NULL);
 }
 
 bool PanelGtk::IsPanelActive() const {
   return is_active_;
 }
 
 void PanelGtk::PreventActivationByOS(bool prevent_activation) {
+  // If the GTK window is set with no focus accepted, it introduces the
+  // following issues:
+  // 1) It cannot be brought to the top by calling gdk_window_raise.
+  // 2) Even after it is forced to the top by calling gtk_window_present or
+  //    gtk_window_set_keep_above, it is not lowered in the z-order when the
+  //    client area of other window is clicked.
+  // When a docked panel is minimized to a few pixel lines, we do not want it
+  // to take focus since the user would have hard time to notice that. However,
+  // when a stacked panel is collapsed to the titlebar-only, focusing on it
+  // seems not to be too bad. Since we do not have other solution to solve

[Dmitry Titov, 2013/06/20 00:57:23]

The main reason for us to avoid focusing is to prevent situations when the panel
is focused and the user keyboard input goes into a chat mole invisibly for the
user (since the panel is in minimized or titlebar-only modes). The potential
issue here is the user sends unwanted input to someone without realizing it.

Another reason is to prevent alt-tab and other methods of cycling Chrome windows
to activate and open the panels - in other words, the rotations should skip the
minimized/titlebar-only panels. The potential issue here is that while cycling
user will mess up their carefully arranged stacks...

I think we want to preserve those..

+  // the two issues mentioned above for stacked panels, we choose not to
+  // prevent activation for non-docked panels.
+  if (panel_->collection()->type() != PanelCollection::DOCKED)
+    prevent_activation = false;
   gtk_window_set_accept_focus(window_, !prevent_activation);
 }
 
 gfx::NativeWindow PanelGtk::GetNativePanelWindow() {
   return window_;
 }
 
 void PanelGtk::UpdatePanelTitleBar() {
   TRACE_EVENT0("ui::gtk", "PanelGtk::UpdatePanelTitleBar");
   string16 title = panel_->GetWindowTitle();
@@ skipping 306 matching lines @@
     default:
       NOTREACHED();
       return false;
   }
   return gtk_widget_get_visible(button->widget());
 }
 
 panel::CornerStyle GtkNativePanelTesting::GetWindowCornerStyle() const {
   return panel_gtk_->corner_style_;
 }