Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: tools/utils.py

Issue 17397005: Bugfix for tools/utils.py: Inherit environment to cmd.exe. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/utils.py
diff --git a/tools/utils.py b/tools/utils.py
index da4266628265cd23c80aee666a4bf74577cebf2e..8346d09546c8f561856e91f463d2ede50a4fec1d 100644
--- a/tools/utils.py
+++ b/tools/utils.py
@@ -239,9 +239,11 @@ def GetVersion():
return output.strip()
def GetSVNRevision():
+ custom_env = dict(os.environ)
+ custom_env['LC_MESSAGES'] = 'en_GB'
p = subprocess.Popen(['svn', 'info'], stdout = subprocess.PIPE,
stderr = subprocess.STDOUT, shell=IsWindows(),
- env = {'LC_MESSAGES' : 'en_GB'})
+ env = custom_env)
output, not_used = p.communicate()
revision = ParseSvnInfoOutput(output)
if revision:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698