Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1739643002: Revert of Add browser tests for FetchEvent.request.mode/credentials in the service worker (Closed)

Created:
4 years, 9 months ago by horo
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add browser tests for FetchEvent.request.mode/credentials in the service worker (patchset #5 id:120001 of https://codereview.chromium.org/1665453003/ ) Reason for revert: https://codereview.chromium.org/1665533003/ introduced a security bug. Original issue's description: > Add browser tests for FetchEvent.request.mode/credentials in the service worker > > This CL adds browser_tests to check the fetch request mode and > credentials mode in the service worker for the follwing requests. > > - <embed src="test.pdf"> > Fetched in MimeHandlerViewContainer::OnReady(). > - <link rel="manifest" href="manifest.json"> > Fetched in ManifestFetcher::Start(). > - PPAPI's pp::URLLoader. > Fetched in PepperURLLoaderHost::InternalOnHostMsgOpen(). > > This CL depends on https://codereview.chromium.org/1665533003/. > > BUG=576534, 543895 > > Committed: https://crrev.com/bcc7a2056bac1159aa480a8fb9355da98f84424c > Cr-Commit-Position: refs/heads/master@{#376704} TBR=jochen@chromium.org,bradnelson@chromium.org,bradnelson@google.com,nhiroki@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=576534, 543895 Committed: https://crrev.com/50ba0ec970300e054957e23e547a2a0d6759afc8 Cr-Commit-Position: refs/heads/master@{#377532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -504 lines) Patch
M chrome/browser/chrome_service_worker_browsertest.cc View 4 chunks +0 lines, -389 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/nacl/BUILD.gn View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/nacl/pnacl_url_loader/pnacl_url_loader.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/test/data/nacl/pnacl_url_loader/pnacl_url_loader.html View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
horo
Created Revert of Add browser tests for FetchEvent.request.mode/credentials in the service worker
4 years, 9 months ago (2016-02-25 06:43:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739643002/1
4 years, 9 months ago (2016-02-25 06:43:58 UTC) #2
nhiroki
> Reason for revert: > https://codereview.chromium.org/1665533003/ introduced a security bug. Did the bug fail these ...
4 years, 9 months ago (2016-02-25 06:51:39 UTC) #3
nhiroki
On 2016/02/25 06:51:39, nhiroki wrote: > > Reason for revert: > > https://codereview.chromium.org/1665533003/ introduced a ...
4 years, 9 months ago (2016-02-25 06:53:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739643002/1
4 years, 9 months ago (2016-02-25 07:02:40 UTC) #5
horo
On 2016/02/25 06:53:18, nhiroki wrote: > On 2016/02/25 06:51:39, nhiroki wrote: > > > Reason ...
4 years, 9 months ago (2016-02-25 07:13:32 UTC) #6
nhiroki
On 2016/02/25 07:13:32, horo wrote: > On 2016/02/25 06:53:18, nhiroki wrote: > > On 2016/02/25 ...
4 years, 9 months ago (2016-02-25 07:16:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739643002/1
4 years, 9 months ago (2016-02-25 07:32:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739643002/1
4 years, 9 months ago (2016-02-25 08:02:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-25 08:12:16 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50ba0ec970300e054957e23e547a2a0d6759afc8 Cr-Commit-Position: refs/heads/master@{#377532}
4 years, 9 months ago (2016-02-25 08:13:23 UTC) #12
horo
4 years, 9 months ago (2016-03-08 23:36:31 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1775143003/ by horo@chromium.org.

The reason for reverting is: Bug fixed cl landed:
https://codereview.chromium.org/1762893002/.

Powered by Google App Engine
This is Rietveld 408576698