Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Side by Side Diff: src/runtime.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4932 matching lines...) Expand 10 before | Expand all | Expand 10 after
4943 : value; 4943 : value;
4944 } 4944 }
4945 // Lookup cache miss. Perform lookup and update the cache if 4945 // Lookup cache miss. Perform lookup and update the cache if
4946 // appropriate. 4946 // appropriate.
4947 LookupResult result(isolate); 4947 LookupResult result(isolate);
4948 receiver->LocalLookup(key, &result); 4948 receiver->LocalLookup(key, &result);
4949 if (result.IsField()) { 4949 if (result.IsField()) {
4950 int offset = result.GetFieldIndex().field_index(); 4950 int offset = result.GetFieldIndex().field_index();
4951 // Do not track double fields in the keyed lookup cache. Reading 4951 // Do not track double fields in the keyed lookup cache. Reading
4952 // double values requires boxing. 4952 // double values requires boxing.
4953 if (!FLAG_track_double_fields || 4953 if (!result.representation().IsDouble()) {
4954 !result.representation().IsDouble()) {
4955 keyed_lookup_cache->Update(receiver_map, key, offset); 4954 keyed_lookup_cache->Update(receiver_map, key, offset);
4956 } 4955 }
4957 return receiver->FastPropertyAt(result.representation(), offset); 4956 return receiver->FastPropertyAt(result.representation(), offset);
4958 } 4957 }
4959 } else { 4958 } else {
4960 // Attempt dictionary lookup. 4959 // Attempt dictionary lookup.
4961 NameDictionary* dictionary = receiver->property_dictionary(); 4960 NameDictionary* dictionary = receiver->property_dictionary();
4962 int entry = dictionary->FindEntry(key); 4961 int entry = dictionary->FindEntry(key);
4963 if ((entry != NameDictionary::kNotFound) && 4962 if ((entry != NameDictionary::kNotFound) &&
4964 (dictionary->DetailsAt(entry).type() == NORMAL)) { 4963 (dictionary->DetailsAt(entry).type() == NORMAL)) {
(...skipping 10000 matching lines...) Expand 10 before | Expand all | Expand 10 after
14965 // Handle last resort GC and make sure to allow future allocations 14964 // Handle last resort GC and make sure to allow future allocations
14966 // to grow the heap without causing GCs (if possible). 14965 // to grow the heap without causing GCs (if possible).
14967 isolate->counters()->gc_last_resort_from_js()->Increment(); 14966 isolate->counters()->gc_last_resort_from_js()->Increment();
14968 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags, 14967 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags,
14969 "Runtime::PerformGC"); 14968 "Runtime::PerformGC");
14970 } 14969 }
14971 } 14970 }
14972 14971
14973 14972
14974 } } // namespace v8::internal 14973 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698