Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4277 matching lines...) Expand 10 before | Expand all | Expand 10 after
4288 } 4288 }
4289 return; 4289 return;
4290 } 4290 }
4291 4291
4292 Register object = ToRegister(instr->object()); 4292 Register object = ToRegister(instr->object());
4293 Handle<Map> transition = instr->transition(); 4293 Handle<Map> transition = instr->transition();
4294 SmiCheck check_needed = 4294 SmiCheck check_needed =
4295 instr->hydrogen()->value()->IsHeapObject() 4295 instr->hydrogen()->value()->IsHeapObject()
4296 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 4296 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
4297 4297
4298 if (FLAG_track_fields && representation.IsSmi()) { 4298 if (representation.IsSmi()) {
4299 if (instr->value()->IsConstantOperand()) { 4299 if (instr->value()->IsConstantOperand()) {
4300 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); 4300 LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
4301 if (!IsSmi(operand_value)) { 4301 if (!IsSmi(operand_value)) {
4302 DeoptimizeIf(no_condition, instr->environment()); 4302 DeoptimizeIf(no_condition, instr->environment());
4303 } 4303 }
4304 } 4304 }
4305 } else if (FLAG_track_heap_object_fields && representation.IsHeapObject()) { 4305 } else if (representation.IsHeapObject()) {
4306 if (instr->value()->IsConstantOperand()) { 4306 if (instr->value()->IsConstantOperand()) {
4307 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); 4307 LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
4308 if (IsInteger32(operand_value)) { 4308 if (IsInteger32(operand_value)) {
4309 DeoptimizeIf(no_condition, instr->environment()); 4309 DeoptimizeIf(no_condition, instr->environment());
4310 } 4310 }
4311 } else { 4311 } else {
4312 if (!instr->hydrogen()->value()->type().IsHeapObject()) { 4312 if (!instr->hydrogen()->value()->type().IsHeapObject()) {
4313 Register value = ToRegister(instr->value()); 4313 Register value = ToRegister(instr->value());
4314 __ test(value, Immediate(kSmiTagMask)); 4314 __ test(value, Immediate(kSmiTagMask));
4315 DeoptimizeIf(zero, instr->environment()); 4315 DeoptimizeIf(zero, instr->environment());
(...skipping 1954 matching lines...) Expand 10 before | Expand all | Expand 10 after
6270 FixedArray::kHeaderSize - kPointerSize)); 6270 FixedArray::kHeaderSize - kPointerSize));
6271 __ bind(&done); 6271 __ bind(&done);
6272 } 6272 }
6273 6273
6274 6274
6275 #undef __ 6275 #undef __
6276 6276
6277 } } // namespace v8::internal 6277 } } // namespace v8::internal
6278 6278
6279 #endif // V8_TARGET_ARCH_IA32 6279 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698