Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1569 matching lines...) Expand 10 before | Expand all | Expand 10 after
1580 1580
1581 expr->BuildConstantProperties(isolate()); 1581 expr->BuildConstantProperties(isolate());
1582 Handle<FixedArray> constant_properties = expr->constant_properties(); 1582 Handle<FixedArray> constant_properties = expr->constant_properties();
1583 int flags = expr->fast_elements() 1583 int flags = expr->fast_elements()
1584 ? ObjectLiteral::kFastElements 1584 ? ObjectLiteral::kFastElements
1585 : ObjectLiteral::kNoFlags; 1585 : ObjectLiteral::kNoFlags;
1586 flags |= expr->has_function() 1586 flags |= expr->has_function()
1587 ? ObjectLiteral::kHasFunction 1587 ? ObjectLiteral::kHasFunction
1588 : ObjectLiteral::kNoFlags; 1588 : ObjectLiteral::kNoFlags;
1589 int properties_count = constant_properties->length() / 2; 1589 int properties_count = constant_properties->length() / 2;
1590 if ((FLAG_track_double_fields && expr->may_store_doubles()) || 1590 if (expr->may_store_doubles() || expr->depth() > 1 || Serializer::enabled() ||
1591 expr->depth() > 1 || Serializer::enabled() ||
1592 flags != ObjectLiteral::kFastElements || 1591 flags != ObjectLiteral::kFastElements ||
1593 properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) { 1592 properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) {
1594 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 1593 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
1595 __ push(FieldOperand(edi, JSFunction::kLiteralsOffset)); 1594 __ push(FieldOperand(edi, JSFunction::kLiteralsOffset));
1596 __ push(Immediate(Smi::FromInt(expr->literal_index()))); 1595 __ push(Immediate(Smi::FromInt(expr->literal_index())));
1597 __ push(Immediate(constant_properties)); 1596 __ push(Immediate(constant_properties));
1598 __ push(Immediate(Smi::FromInt(flags))); 1597 __ push(Immediate(Smi::FromInt(flags)));
1599 __ CallRuntime(Runtime::kCreateObjectLiteral, 4); 1598 __ CallRuntime(Runtime::kCreateObjectLiteral, 4);
1600 } else { 1599 } else {
1601 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 1600 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
(...skipping 3310 matching lines...) Expand 10 before | Expand all | Expand 10 after
4912 4911
4913 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4912 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4914 Assembler::target_address_at(call_target_address)); 4913 Assembler::target_address_at(call_target_address));
4915 return OSR_AFTER_STACK_CHECK; 4914 return OSR_AFTER_STACK_CHECK;
4916 } 4915 }
4917 4916
4918 4917
4919 } } // namespace v8::internal 4918 } } // namespace v8::internal
4920 4919
4921 #endif // V8_TARGET_ARCH_IA32 4920 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698