Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4037 matching lines...) Expand 10 before | Expand all | Expand 10 after
4048 MemOperand operand = MemOperand(object, offset); 4048 MemOperand operand = MemOperand(object, offset);
4049 __ Store(value, operand, representation); 4049 __ Store(value, operand, representation);
4050 return; 4050 return;
4051 } 4051 }
4052 4052
4053 Handle<Map> transition = instr->transition(); 4053 Handle<Map> transition = instr->transition();
4054 SmiCheck check_needed = 4054 SmiCheck check_needed =
4055 instr->hydrogen()->value()->IsHeapObject() 4055 instr->hydrogen()->value()->IsHeapObject()
4056 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 4056 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
4057 4057
4058 if (FLAG_track_heap_object_fields && representation.IsHeapObject()) { 4058 if (representation.IsHeapObject()) {
4059 Register value = ToRegister(instr->value()); 4059 Register value = ToRegister(instr->value());
4060 if (!instr->hydrogen()->value()->type().IsHeapObject()) { 4060 if (!instr->hydrogen()->value()->type().IsHeapObject()) {
4061 __ SmiTst(value); 4061 __ SmiTst(value);
4062 DeoptimizeIf(eq, instr->environment()); 4062 DeoptimizeIf(eq, instr->environment());
4063 4063
4064 // We know that value is a smi now, so we can omit the check below. 4064 // We know that value is a smi now, so we can omit the check below.
4065 check_needed = OMIT_SMI_CHECK; 4065 check_needed = OMIT_SMI_CHECK;
4066 } 4066 }
4067 } else if (representation.IsDouble()) { 4067 } else if (representation.IsDouble()) {
4068 ASSERT(transition.is_null()); 4068 ASSERT(transition.is_null());
(...skipping 1673 matching lines...) Expand 10 before | Expand all | Expand 10 after
5742 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5742 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5743 __ ldr(result, FieldMemOperand(scratch, 5743 __ ldr(result, FieldMemOperand(scratch,
5744 FixedArray::kHeaderSize - kPointerSize)); 5744 FixedArray::kHeaderSize - kPointerSize));
5745 __ bind(&done); 5745 __ bind(&done);
5746 } 5746 }
5747 5747
5748 5748
5749 #undef __ 5749 #undef __
5750 5750
5751 } } // namespace v8::internal 5751 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698