Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/a64/lithium-a64.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/full-codegen-a64.cc ('k') | src/a64/lithium-codegen-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2114 matching lines...) Expand 10 before | Expand all | Expand 10 after
2125 // TODO(jbramley): It might be beneficial to allow value to be a constant in 2125 // TODO(jbramley): It might be beneficial to allow value to be a constant in
2126 // some cases. x64 makes use of this with FLAG_track_fields, for example. 2126 // some cases. x64 makes use of this with FLAG_track_fields, for example.
2127 2127
2128 LOperand* object = UseRegister(instr->object()); 2128 LOperand* object = UseRegister(instr->object());
2129 LOperand* value = UseRegisterAndClobber(instr->value()); 2129 LOperand* value = UseRegisterAndClobber(instr->value());
2130 LOperand* temp0 = TempRegister(); 2130 LOperand* temp0 = TempRegister();
2131 LOperand* temp1 = TempRegister(); 2131 LOperand* temp1 = TempRegister();
2132 2132
2133 LStoreNamedField* result = 2133 LStoreNamedField* result =
2134 new(zone()) LStoreNamedField(object, value, temp0, temp1); 2134 new(zone()) LStoreNamedField(object, value, temp0, temp1);
2135 if (FLAG_track_heap_object_fields && 2135 if (instr->field_representation().IsHeapObject() &&
2136 instr->field_representation().IsHeapObject() &&
2137 !instr->value()->type().IsHeapObject()) { 2136 !instr->value()->type().IsHeapObject()) {
2138 return AssignEnvironment(result); 2137 return AssignEnvironment(result);
2139 } 2138 }
2140 return result; 2139 return result;
2141 } 2140 }
2142 2141
2143 2142
2144 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2143 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2145 LOperand* context = UseFixed(instr->context(), cp); 2144 LOperand* context = UseFixed(instr->context(), cp);
2146 LOperand* object = UseFixed(instr->object(), x1); 2145 LOperand* object = UseFixed(instr->object(), x1);
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
2440 2439
2441 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) { 2440 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
2442 LOperand* receiver = UseRegister(instr->receiver()); 2441 LOperand* receiver = UseRegister(instr->receiver());
2443 LOperand* function = UseRegister(instr->function()); 2442 LOperand* function = UseRegister(instr->function());
2444 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function); 2443 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function);
2445 return AssignEnvironment(DefineAsRegister(result)); 2444 return AssignEnvironment(DefineAsRegister(result));
2446 } 2445 }
2447 2446
2448 2447
2449 } } // namespace v8::internal 2448 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/a64/full-codegen-a64.cc ('k') | src/a64/lithium-codegen-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698