Rename some functions that start with underscore.

Rename some functions that start with underscore.

Fix misc issues along the way.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/4467dea020b2c19588cc06ce1ece46cd99f3c7df

[Lei Zhang, 2016-02-25 05:31:02]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-02-25 19:00:39]

lgtm

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
File core/src/fxcodec/lbmp/fx_bmp.cpp (right):

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:105:
(FX_DWORD)GetWord_LSBFirst((uint8_t*)&bmp_core_header_ptr->bcWidth);
nit: do we need the casts to FX_DWORD since its just a uint16 to uint32
assignment?

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:686: SetDWord_LSBFirst(&dst_buf[offset],
(FX_DWORD)info_head_ptr->biWidth);
nit: Do we need the casts here,too?

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:783: SetWord_LSBFirst(&dst_buf[dst_pos],
(FX_WORD)pix_val);
nit: ditto

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:798: #ifdef BMP_SUPPORT_BITFIELD
nit: always true?

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gif.h
File core/src/fxcodec/lgif/fx_gif.h (right):

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:207: void
(*_gif_error_fn)(gif_decompress_struct_p gif_ptr,
no leading _ ?

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:224: uint8_t*
(*_gif_ask_buf_for_pal_fn)(gif_decompress_struct_p gif_ptr,
here, too, and below?

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:241: #ifdef GIF_SUPPORT_APPLICATION_EXTENSION
never true?

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:247: #ifdef GIF_SUPPORT_COMMENT_EXTENSION
always true?

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:250: #ifdef GIF_SUPPORT_GRAPHIC_CONTROL_EXTENSION
always true

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:253: #ifdef GIF_SUPPORT_PLAIN_TEXT_EXTENSION
always true

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:275: #ifdef GIF_SUPPORT_APPLICATION_EXTENSION
same here.

[Lei Zhang, 2016-02-25 20:38:37]

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
File core/src/fxcodec/lbmp/fx_bmp.cpp (right):

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:105:
(FX_DWORD)GetWord_LSBFirst((uint8_t*)&bmp_core_header_ptr->bcWidth);
On 2016/02/25 19:00:39, Tom Sepez wrote:
> nit: do we need the casts to FX_DWORD since its just a uint16 to uint32
> assignment?

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:686: SetDWord_LSBFirst(&dst_buf[offset],
(FX_DWORD)info_head_ptr->biWidth);
On 2016/02/25 19:00:39, Tom Sepez wrote:
> nit: Do we need the casts here,too?

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:783: SetWord_LSBFirst(&dst_buf[dst_pos],
(FX_WORD)pix_val);
On 2016/02/25 19:00:39, Tom Sepez wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lbmp/fx_bm...
core/src/fxcodec/lbmp/fx_bmp.cpp:798: #ifdef BMP_SUPPORT_BITFIELD
On 2016/02/25 19:00:39, Tom Sepez wrote:
> nit: always true?

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gif.h
File core/src/fxcodec/lgif/fx_gif.h (right):

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:207: void
(*_gif_error_fn)(gif_decompress_struct_p gif_ptr,
On 2016/02/25 19:00:39, Tom Sepez wrote:
> no leading _ ?

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:224: uint8_t*
(*_gif_ask_buf_for_pal_fn)(gif_decompress_struct_p gif_ptr,
On 2016/02/25 19:00:39, Tom Sepez wrote:
> here, too, and below?

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:241: #ifdef GIF_SUPPORT_APPLICATION_EXTENSION
On 2016/02/25 19:00:39, Tom Sepez wrote:
> never true?

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:247: #ifdef GIF_SUPPORT_COMMENT_EXTENSION
On 2016/02/25 19:00:39, Tom Sepez wrote:
> always true?

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:250: #ifdef GIF_SUPPORT_GRAPHIC_CONTROL_EXTENSION
On 2016/02/25 19:00:39, Tom Sepez wrote:
> always true

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:253: #ifdef GIF_SUPPORT_PLAIN_TEXT_EXTENSION
On 2016/02/25 19:00:39, Tom Sepez wrote:
> always true

Done.

https://codereview.chromium.org/1739623002/diff/1/core/src/fxcodec/lgif/fx_gi...
core/src/fxcodec/lgif/fx_gif.h:275: #ifdef GIF_SUPPORT_APPLICATION_EXTENSION
On 2016/02/25 19:00:39, Tom Sepez wrote:
> same here.

Done.

[Lei Zhang, 2016-02-25 20:39:21]

Description was changed from

==========
Rename some functions that start with underscore.

Fix misc issues along the way.
==========

to

==========
Rename some functions that start with underscore.

Fix misc issues along the way.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/4467dea020b2c19588cc06ce1ece46cd99f3...
==========

[Lei Zhang, 2016-02-25 20:39:22]

Committed patchset #2 (id:20001) manually as
4467dea020b2c19588cc06ce1ece46cd99f3c7df (presubmit successful).