third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template - Issue 1739613002: DevTools: validate protocol input parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

Issue 1739613002: DevTools: validate protocol input parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined a test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template ('k') | third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

index 6fd0b720c32bd5a0b68c010b94acd973ce707bd0..ae449fefad71d8aed92f6cdb9ca9ee731b92f0af 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

@@ -29,7 +29,7 @@ public:

bool isActive();

protected:

- void sendIfActive(PassRefPtr<JSONObject> partialMessage, const ErrorString& invocationError, PassRefPtr<JSONValue> errorData);

+ void sendIfActive(PassRefPtr<JSONObject> partialMessage, const ErrorString& invocationError);

private:

void disable() { m_alreadySent = true; }

@@ -108,7 +108,7 @@ public:

};

void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String& errorMessage) const;

- virtual void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String& errorMessage, PassRefPtr<JSONValue> data) const = 0;

+ virtual void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String& errorMessage, ErrorSupport*) const = 0;

virtual void dispatch(int sessionId, const String& message) = 0;

static bool getCommandName(const String& message, String* result);

};