Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: runtime/vm/aot_optimizer.cc

Issue 1739593002: Revert "Move precompilation-related flags to flags list." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/regexp.cc ('k') | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/aot_optimizer.cc
diff --git a/runtime/vm/aot_optimizer.cc b/runtime/vm/aot_optimizer.cc
index 09582888ce4d53ea642e65677555d9922267bda6..f9f9c243f22884726ad4e71a58ae42e36ddf7a24 100644
--- a/runtime/vm/aot_optimizer.cc
+++ b/runtime/vm/aot_optimizer.cc
@@ -29,6 +29,8 @@
namespace dart {
+DECLARE_FLAG(bool, precompilation);
+
// Quick access to the current isolate and zone.
#define I (isolate())
#define Z (zone())
@@ -2032,7 +2034,7 @@ bool AotOptimizer::TryInlineFloat32x4Constructor(
StaticCallInstr* call,
MethodRecognizer::Kind recognized_kind) {
// Cannot handle unboxed instructions.
- ASSERT(FLAG_precompiled_mode);
+ ASSERT(FLAG_precompilation);
return false;
}
@@ -2041,7 +2043,7 @@ bool AotOptimizer::TryInlineFloat64x2Constructor(
StaticCallInstr* call,
MethodRecognizer::Kind recognized_kind) {
// Cannot handle unboxed instructions.
- ASSERT(FLAG_precompiled_mode);
+ ASSERT(FLAG_precompilation);
return false;
}
@@ -2050,7 +2052,7 @@ bool AotOptimizer::TryInlineInt32x4Constructor(
StaticCallInstr* call,
MethodRecognizer::Kind recognized_kind) {
// Cannot handle unboxed instructions.
- ASSERT(FLAG_precompiled_mode);
+ ASSERT(FLAG_precompilation);
return false;
}
@@ -2547,7 +2549,7 @@ void AotOptimizer::InstanceCallNoopt(InstanceCallInstr* instr) {
// Tries to optimize instance call by replacing it with a faster instruction
// (e.g, binary op, field load, ..).
void AotOptimizer::VisitInstanceCall(InstanceCallInstr* instr) {
- ASSERT(FLAG_precompiled_mode);
+ ASSERT(FLAG_precompilation);
InstanceCallNoopt(instr);
}
@@ -2574,7 +2576,7 @@ void AotOptimizer::VisitStaticCall(StaticCallInstr* call) {
break;
}
if (unary_kind != MathUnaryInstr::kIllegal) {
- ASSERT(FLAG_precompiled_mode);
+ ASSERT(FLAG_precompilation);
// TODO(srdjan): Adapt MathUnaryInstr to allow tagged inputs as well.
return;
}
@@ -2654,7 +2656,7 @@ void AotOptimizer::VisitStaticCall(StaticCallInstr* call) {
case MethodRecognizer::kMathAcos:
case MethodRecognizer::kMathAtan:
case MethodRecognizer::kMathAtan2: {
- ASSERT(FLAG_precompiled_mode);
+ ASSERT(FLAG_precompilation);
// No UnboxDouble instructions allowed.
return;
}
« no previous file with comments | « runtime/lib/regexp.cc ('k') | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698