Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1739553003: Move errors for bad imports and exports to the directive (Closed)

Created:
4 years, 10 months ago by skybrian
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move errors for bad imports and exports to the directive This is to ensure that error.source matches the source of the ChangeNotice it appears in and the analysis server will report the error together with other errors for the same file. (Moving the error seems easier than figuring out how to put it on a different Source, and it might be that the import/export is at fault anyway.) BUG=https://github.com/dart-lang/sdk/issues/25826 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/b9e03197638107a89706dae387e8e733992ecbcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 4 chunks +21 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
skybrian
4 years, 10 months ago (2016-02-25 03:40:37 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-25 15:24:57 UTC) #3
skybrian
4 years, 10 months ago (2016-02-25 19:48:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9e03197638107a89706dae387e8e733992ecbcc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698