Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1739553002: Pull up a subset of CanvasRenderingContext2D into BaseRenderingContext2D. (Closed)

Created:
4 years, 10 months ago by ikilpatrick
Modified:
4 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, ajuma+watch-canvas_chromium.org, Rik, dshwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull up a subset of CanvasRenderingContext2D into BaseRenderingContext2D. This will allow an additional sub-class of BaseRC2D called PaintRC2D. BaseRC2D contains the subset of APIs needed for PaintRC2D. See: https://drafts.css-houdini.org/css-paint-api/#paintrenderingcontext2d This is a reland of: https://codereview.chromium.org/1710633002 BUG=578252 Committed: https://crrev.com/b1592675744d6ebd5f7968daf455c34703ba9488 Cr-Commit-Position: refs/heads/master@{#377628}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -2875 lines) Patch
A + third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 5 chunks +143 lines, -186 lines 1 comment Download
A + third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 61 chunks +131 lines, -1142 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 8 chunks +28 lines, -140 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 12 chunks +54 lines, -1407 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ikilpatrick
Had some fun with non-working trybots today. win_blink_oilpan_dbg should pass now (which is a non-oilpan ...
4 years, 10 months ago (2016-02-25 00:58:17 UTC) #2
Justin Novosad
Thanks for figuring this out. lgtm. The failures in the current try look unrelated to ...
4 years, 10 months ago (2016-02-25 16:05:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739553002/1
4 years, 10 months ago (2016-02-25 16:08:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 18:51:09 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 18:53:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1592675744d6ebd5f7968daf455c34703ba9488
Cr-Commit-Position: refs/heads/master@{#377628}

Powered by Google App Engine
This is Rietveld 408576698