Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 1739523002: WebUsb Android chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 6018e4e10572b448cfe297ff52b26d307dd1c36e..482f4d35c02462ce332a301ecf13e756afb8addd 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -154,6 +154,7 @@
#include "content/public/common/service_registry.h"
#include "content/public/common/url_utils.h"
#include "content/public/common/web_preferences.h"
+#include "device/usb/public/interfaces/chooser_service.mojom.h"
#include "device/usb/public/interfaces/device_manager.mojom.h"
#include "gin/v8_initializer.h"
#include "mojo/shell/public/cpp/shell_client.h"
@@ -293,10 +294,6 @@
#include "chrome/browser/media/router/presentation_service_delegate_impl.h"
#endif
-#if !defined(OS_ANDROID)
-#include "device/usb/public/interfaces/chooser_service.mojom.h"
-#endif
-
#if defined(ENABLE_WAYLAND_SERVER)
#include "chrome/browser/chrome_browser_main_extra_parts_exo.h"
#endif
@@ -689,7 +686,6 @@ void CreateUsbDeviceManager(
tab_helper->CreateDeviceManager(render_frame_host, std::move(request));
}
-#if !defined(OS_ANDROID)
void CreateWebUsbChooserService(
RenderFrameHost* render_frame_host,
mojo::InterfaceRequest<device::usb::ChooserService> request) {
@@ -704,7 +700,6 @@ void CreateWebUsbChooserService(
UsbTabHelper::GetOrCreateForWebContents(web_contents);
tab_helper->CreateChooserService(render_frame_host, std::move(request));
}
-#endif // !defined(OS_ANDROID)
bool GetDataSaverEnabledPref(const PrefService* prefs) {
// Enable data saver only when data saver pref is enabled and not part of
@@ -2790,10 +2785,8 @@ void ChromeContentBrowserClient::RegisterRenderFrameMojoServices(
content::ServiceRegistry* registry,
content::RenderFrameHost* render_frame_host) {
registry->AddService(base::Bind(&CreateUsbDeviceManager, render_frame_host));
-#if !defined(OS_ANDROID)
registry->AddService(
base::Bind(&CreateWebUsbChooserService, render_frame_host));
-#endif // !defined(OS_ANDROID)
}
void ChromeContentBrowserClient::RegisterInProcessMojoApplications(

Powered by Google App Engine
This is Rietveld 408576698