WebUsb Android chooser UI

chrome/browser/usb/usb_common.h

Index: chrome/browser/usb/usb_common.h
diff --git a/chrome/browser/usb/usb_common.h b/chrome/browser/usb/usb_common.h
new file mode 100644
index 0000000000000000000000000000000000000000..fdc73107640845341bd86e71eab45ce3f6b24253
--- /dev/null
+++ b/chrome/browser/usb/usb_common.h
@@ -0,0 +1,39 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_USB_USB_COMMON_H_
+#define CHROME_BROWSER_USB_USB_COMMON_H_
+
+class GURL;
+
+namespace device {
+struct WebUsbAllowedOrigins;
+}
+
+// Reasons the chooser may be closed. These are used in histograms so do not
+// remove/reorder entries. Only add at the end just before
+// WEBUSB_CHOOSER_CLOSED_MAX. Also remember to update the enum listing in
+// tools/metrics/histograms/histograms.xml.
+enum WebUsbChooserClosed {
+  // The user cancelled the permission prompt without selecting a device.
+  WEBUSB_CHOOSER_CLOSED_CANCELLED = 0,
+  // The user probably cancelled the permission prompt without selecting a
+  // device because there were no devices to select.
+  WEBUSB_CHOOSER_CLOSED_CANCELLED_NO_DEVICES,
+  // The user granted permission to access a device.
+  WEBUSB_CHOOSER_CLOSED_PERMISSION_GRANTED,
+  // The user granted permission to access a device but that permission will be
+  // revoked when the device is disconnected.
+  WEBUSB_CHOOSER_CLOSED_EPHEMERAL_PERMISSION_GRANTED,
+  // Maximum value for the enum.
+  WEBUSB_CHOOSER_CLOSED_MAX
+};
+
+void RecordChooserClosure(WebUsbChooserClosed disposition);
+
+// Check if the origin is allowed.
+bool FindInAllowedOrigins(const device::WebUsbAllowedOrigins* allowed_origins,

[Reilly Grant (use Gerrit), 2016/03/04 20:53:39]

These functions should have more specific names now that they are no longer
private. I suggest RecordWebUsbChooserClosure and FindInWebUsbAllowedOrigins.
The latter may also be added to device::WebUsbAllowedOrigins. Then this file
could simply be web_usb_histograms.h.

[juncai, 2016/03/05 00:18:25]

Done.

+                          const GURL& origin);
+
+#endif  // CHROME_BROWSER_USB_USB_COMMON_H_