Makes the OfflinePageBridge.getAllPages method asynchronous.

components/offline_pages/offline_page_model.cc

Index: components/offline_pages/offline_page_model.cc
diff --git a/components/offline_pages/offline_page_model.cc b/components/offline_pages/offline_page_model.cc
index 7f4b60c139732de21e127b328f02147cd22f4c43..7974f8dba9f1082ee15378bb3c2435a33fa003ab 100644
--- a/components/offline_pages/offline_page_model.cc
+++ b/components/offline_pages/offline_page_model.cc
@@ -232,15 +232,6 @@ void OfflinePageModel::MarkPageForDeletion(int64_t bookmark_id,
                  weak_ptr_factory_.GetWeakPtr(), offline_page_item, callback));
 }
 
-void OfflinePageModel::DeletePageByBookmarkId(
-    int64_t bookmark_id,
-    const DeletePageCallback& callback) {
-  DCHECK(is_loaded_);
-  std::vector<int64_t> bookmark_ids_to_delete;
-  bookmark_ids_to_delete.push_back(bookmark_id);
-  DeletePagesByBookmarkId(bookmark_ids_to_delete, callback);
-}
-
 void OfflinePageModel::DeletePagesByBookmarkId(
     const std::vector<int64_t>& bookmark_ids,
     const DeletePageCallback& callback) {
@@ -535,8 +526,10 @@ void OfflinePageModel::BookmarkNodeChanged(
   // BookmarkNodeChanged could be triggered if title or URL gets changed. If
   // the latter, we need to invalidate the offline copy.
   auto iter = offline_pages_.find(node->id());
-  if (iter != offline_pages_.end() && iter->second.url != node->url())
-    DeletePageByBookmarkId(node->id(), DeletePageCallback());
+  if (iter != offline_pages_.end() && iter->second.url != node->url()) {
+    DeletePagesByBookmarkId(std::vector<int64_t>(1, node->id()),

[fgorski, 2016/02/26 21:31:10]

ugly, do we need this?
Will the offline_id patch not help us here?

[dewittj, 2016/03/01 22:28:52]

Done.

+                            DeletePageCallback());
+  }
 }
 
 void OfflinePageModel::OnEnsureArchivesDirCreatedDone() {