Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3812)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1739503002: Makes the OfflinePageBridge.getAllPages method asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix some comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index eb212d34e0ffb4f96e5b98cfcf10f5494aa33f2d..484461ab4d79fd43049234fc417940313995bfad 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -244,19 +244,6 @@ void OfflinePageBridge::MarkPageAccessed(JNIEnv* env,
offline_page_model_->MarkPageAccessed(offline_id);
}
-void OfflinePageBridge::DeletePage(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& j_callback_obj,
- jlong offline_id) {
- DCHECK(j_callback_obj);
-
- ScopedJavaGlobalRef<jobject> j_callback_ref;
- j_callback_ref.Reset(env, j_callback_obj);
-
- offline_page_model_->DeletePageByOfflineId(
- offline_id, base::Bind(&DeletePageCallback, j_callback_ref));
-}
-
void OfflinePageBridge::DeletePages(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.h ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698