chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 1739503002: Makes the OfflinePageBridge.getAllPages method asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1739503002: Makes the OfflinePageBridge.getAllPages method asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Wait for model load in new async method. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java ('K') | « chrome/browser/android/offline_pages/offline_page_bridge.h ('k') | components/offline_pages/offline_page_model.cc » ('j') | components/offline_pages/offline_page_model_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index c5021b8d5065713e14b05b2f6cdd2b4aded9d32e..2880d4c961e6166c835d7f95ef6c092b486fbfc4 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -244,19 +244,6 @@ void OfflinePageBridge::MarkPageAccessed(JNIEnv* env,

offline_page_model_->MarkPageAccessed(offline_id);

}

-void OfflinePageBridge::DeletePage(JNIEnv* env,

- const JavaParamRef<jobject>& obj,

- const JavaParamRef<jobject>& j_callback_obj,

- jlong offline_id) {

- DCHECK(j_callback_obj);

- ScopedJavaGlobalRef<jobject> j_callback_ref;

- j_callback_ref.Reset(env, j_callback_obj);

- offline_page_model_->DeletePageByOfflineId(

- offline_id, base::Bind(&DeletePageCallback, j_callback_ref));

void OfflinePageBridge::DeletePages(

JNIEnv* env,

const JavaParamRef<jobject>& obj,