Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 17395002: content_shell: Use a ThreadRestrictions::ScopedAllowWait for layout tests on Android. (Closed)

Created:
7 years, 6 months ago by Peter Beverloo
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

content_shell: Use a ThreadRestrictions::ScopedAllowWait for layout tests on Android. Because of the nested message pump implementation used by Android for running layout tests, which uses a base::WaitableEvent to wait for new messages, we need to allow waiting on the UI thread. The ScopedAllowWaitForAndroidLayoutTest class has been implemented as a member of the WebKitTestController, to ensure that the exception's lifetime is tied to the layout test controller itself. BUG=232044 R=jam@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207523

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M base/threading/thread_restrictions.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/webkit_test_controller.h View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Beverloo
7 years, 6 months ago (2013-06-18 16:41:41 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 6 months ago (2013-06-18 18:20:26 UTC) #2
jam
lgtm
7 years, 6 months ago (2013-06-18 23:21:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/17395002/4001
7 years, 6 months ago (2013-06-18 23:42:07 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-19 00:23:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/17395002/3003
7 years, 6 months ago (2013-06-19 10:46:52 UTC) #6
Peter Beverloo
7 years, 6 months ago (2013-06-20 20:02:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r207523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698