Cleanups related to SkFixed.

Cleanups related to SkFixed.

This CL relands https://codereview.chromium.org/1683743005/ with two fixes:
  - Removing the test for vertical text. Vertical text doesn't work on Windows and breakText isn't supported for non-trivial text.
  - Omit PaintBreakTextTest in Google3 because we don't have the correct font setup yet.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005

Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

patch from issue 1683743005 at patchset 120001 (http://crrev.com/1683743005#ps120001)

Committed: https://skia.googlesource.com/skia/+/f6bfccd562f4ac071db9902097ad4bea83294085

[dogben, 2016-02-24 20:11:53]

benjaminwagner@google.com changed reviewers:
+ reed@google.com

[dogben, 2016-02-24 20:16:42]

Description was changed from

==========
Cleanups related to SkFixed.

This CL relands https://codereview.chromium.org/1683743005/ after removing the
test for vertical text. Vertical text doesn't work on Windows and breakText
isn't supported for non-trivial text.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia,
Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT).
I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia,
Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can
handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

patch from issue 1683743005 at patchset 120001
(http://crrev.com/1683743005#ps120001)
==========

to

==========
Cleanups related to SkFixed.

This CL relands https://codereview.chromium.org/1683743005/ with two fixes:
  - Removing the test for vertical text. Vertical text doesn't work on Windows
and breakText isn't supported for non-trivial text.
  - Omit PaintBreakTextTest in Google3 because we don't have the correct font
setup yet.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia,
Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT).
I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia,
Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can
handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

patch from issue 1683743005 at patchset 120001
(http://crrev.com/1683743005#ps120001)
==========

[dogben, 2016-02-24 20:16:48]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 20:16:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739453002/20001

[commit-bot: I haz the power, 2016-02-24 20:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 20:39:12]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-02-25 18:23:20]

lgtm

[dogben, 2016-02-25 18:27:15]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2016-02-25 18:27:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739453002/20001

[commit-bot: I haz the power, 2016-02-25 18:28:14]

Description was changed from

==========
Cleanups related to SkFixed.

This CL relands https://codereview.chromium.org/1683743005/ with two fixes:
  - Removing the test for vertical text. Vertical text doesn't work on Windows
and breakText isn't supported for non-trivial text.
  - Omit PaintBreakTextTest in Google3 because we don't have the correct font
setup yet.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia,
Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT).
I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia,
Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can
handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

patch from issue 1683743005 at patchset 120001
(http://crrev.com/1683743005#ps120001)
==========

to

==========
Cleanups related to SkFixed.

This CL relands https://codereview.chromium.org/1683743005/ with two fixes:
  - Removing the test for vertical text. Vertical text doesn't work on Windows
and breakText isn't supported for non-trivial text.
  - Omit PaintBreakTextTest in Google3 because we don't have the correct font
setup yet.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia,
Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT).
I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia,
Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can
handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

patch from issue 1683743005 at patchset 120001
(http://crrev.com/1683743005#ps120001)

Committed:
https://skia.googlesource.com/skia/+/f6bfccd562f4ac071db9902097ad4bea83294085
==========

[commit-bot: I haz the power, 2016-02-25 18:28:15]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f6bfccd562f4ac071db9902097ad4bea83294085