Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl

Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl (patchset #2 id:20001 of https://codereview.chromium.org/1676833002/ )

Reason for revert:
This workaround should no longer be needed, per comment#16 from
thakis@ on the original CL.

Original issue's description:
> Add non-inline SkRTreeFactory constructor to fix clang-cl
> 
> When Chromium is switched to build with VS 2015 that switches clang-cl
> to build in -fmsc-version=1900 mode. This causes some changes in
> importing of constructors and vftables which leads to link errors in
> blink_platform.dll. Adding a non-inline constructor makes 1900 mode
> behave consistently with 1800 mode and avoids the link error.
> 
> The root cause needs investigation but this will unblock the VS 2015
> switch.
> 
> BUG=440500, 498544
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676833002
> 
> Committed: https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92

TBR=reed@google.com,bsalomon@google.com,mtklein@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500, 498544
Committed: https://skia.googlesource.com/skia/+/0fe12bcfb79de1d1066a4c3213184dbf2aac1321

[brucedawson, 2016-02-26 20:31:19]

Created Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl

[brucedawson, 2016-02-26 20:32:23]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 20:32:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739363002/1

[commit-bot: I haz the power, 2016-02-26 20:32:30]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-02-27 02:32 UTC

[bsalomon, 2016-02-26 21:03:34]

On 2016/02/26 20:32:30, commit-bot: I haz the power wrote:
> Note for Reviewers:
> The CQ is waiting for an approval.
> If you believe that the CL is not ready yet, or if you would like to L-G-T-M
> with comments then please uncheck the CQ checkbox.
> 
> Waiting for LGTM from valid reviewer(s) till 2016-02-27 02:32 UTC

lgtm

[commit-bot: I haz the power, 2016-02-26 21:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 21:05:24]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-02-27 00:30:12]

Description was changed from

==========
Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl (patchset #2
id:20001 of https://codereview.chromium.org/1676833002/ )

Reason for revert:
This workaround should no longer be needed.

Original issue's description:
> Add non-inline SkRTreeFactory constructor to fix clang-cl
> 
> When Chromium is switched to build with VS 2015 that switches clang-cl
> to build in -fmsc-version=1900 mode. This causes some changes in
> importing of constructors and vftables which leads to link errors in
> blink_platform.dll. Adding a non-inline constructor makes 1900 mode
> behave consistently with 1800 mode and avoids the link error.
> 
> The root cause needs investigation but this will unblock the VS 2015
> switch.
> 
> BUG=440500,498544
> GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
> 
> Committed:
https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92

TBR=reed@google.com,bsalomon@google.com,mtklein@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,498544
==========

to

==========
Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl (patchset #2
id:20001 of https://codereview.chromium.org/1676833002/ )

Reason for revert:
This workaround should no longer be needed, per comment#16 from
thakis@ on the original CL.

Original issue's description:
> Add non-inline SkRTreeFactory constructor to fix clang-cl
> 
> When Chromium is switched to build with VS 2015 that switches clang-cl
> to build in -fmsc-version=1900 mode. This causes some changes in
> importing of constructors and vftables which leads to link errors in
> blink_platform.dll. Adding a non-inline constructor makes 1900 mode
> behave consistently with 1800 mode and avoids the link error.
> 
> The root cause needs investigation but this will unblock the VS 2015
> switch.
> 
> BUG=440500,498544
> GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
> 
> Committed:
https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92

TBR=reed@google.com,bsalomon@google.com,mtklein@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,498544
==========

[brucedawson, 2016-02-27 00:30:19]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-02-27 00:30:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739363002/1

[commit-bot: I haz the power, 2016-02-27 00:31:15]

Description was changed from

==========
Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl (patchset #2
id:20001 of https://codereview.chromium.org/1676833002/ )

Reason for revert:
This workaround should no longer be needed, per comment#16 from
thakis@ on the original CL.

Original issue's description:
> Add non-inline SkRTreeFactory constructor to fix clang-cl
> 
> When Chromium is switched to build with VS 2015 that switches clang-cl
> to build in -fmsc-version=1900 mode. This causes some changes in
> importing of constructors and vftables which leads to link errors in
> blink_platform.dll. Adding a non-inline constructor makes 1900 mode
> behave consistently with 1800 mode and avoids the link error.
> 
> The root cause needs investigation but this will unblock the VS 2015
> switch.
> 
> BUG=440500,498544
> GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
> 
> Committed:
https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92

TBR=reed@google.com,bsalomon@google.com,mtklein@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,498544
==========

to

==========
Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl (patchset #2
id:20001 of https://codereview.chromium.org/1676833002/ )

Reason for revert:
This workaround should no longer be needed, per comment#16 from
thakis@ on the original CL.

Original issue's description:
> Add non-inline SkRTreeFactory constructor to fix clang-cl
> 
> When Chromium is switched to build with VS 2015 that switches clang-cl
> to build in -fmsc-version=1900 mode. This causes some changes in
> importing of constructors and vftables which leads to link errors in
> blink_platform.dll. Adding a non-inline constructor makes 1900 mode
> behave consistently with 1800 mode and avoids the link error.
> 
> The root cause needs investigation but this will unblock the VS 2015
> switch.
> 
> BUG=440500,498544
> GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
> 
> Committed:
https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92

TBR=reed@google.com,bsalomon@google.com,mtklein@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,498544

Committed:
https://skia.googlesource.com/skia/+/0fe12bcfb79de1d1066a4c3213184dbf2aac1321
==========

[commit-bot: I haz the power, 2016-02-27 00:31:15]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0fe12bcfb79de1d1066a4c3213184dbf2aac1321