Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1739223002: Update distribution correctly after mutating fallback content (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
tkent, kochi
CC:
chromium-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update distribution correctly after mutating fallback content Set needsDistributionRecalc flag correctly if a slot's distributed nodes change due to the change of fallback contents. BUG=531990 Committed: https://crrev.com/be045faa0561c7c96522d00fa8b85fe13ae722ce Cr-Commit-Position: refs/heads/master@{#377831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
A + third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-fallback-api-4.html View 2 chunks +9 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739223002/1
4 years, 10 months ago (2016-02-26 05:18:38 UTC) #2
hayato
PTAL
4 years, 10 months ago (2016-02-26 05:39:18 UTC) #5
kochi
lgtm
4 years, 10 months ago (2016-02-26 06:17:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739223002/1
4 years, 10 months ago (2016-02-26 06:25:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 06:34:58 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 06:36:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be045faa0561c7c96522d00fa8b85fe13ae722ce
Cr-Commit-Position: refs/heads/master@{#377831}

Powered by Google App Engine
This is Rietveld 408576698