Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1739203004: Add support for Attachment Brokering of IPC::Channels on multiple threads. (Closed)

Created:
4 years, 10 months ago by erikchen
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for Attachment Brokering of IPC::Channels on multiple threads. Attachment brokering makes the assumption that there's a single thread on which IO related to IPC::Channels occurs. This assumption is violated when the flag --single-process is set. BUG=590213 Committed: https://crrev.com/a91d0513fa16b2e8c48acbaf7a5c18659ab10d07 Cr-Commit-Position: refs/heads/master@{#382431}

Patch Set 1 #

Patch Set 2 : Compile errors. #

Patch Set 3 : Fix windows comiple error. #

Total comments: 2

Patch Set 4 : Comments from sergeyu. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -26 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M ipc/attachment_broker.h View 2 chunks +6 lines, -1 line 0 comments Download
M ipc/attachment_broker.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_privileged.h View 3 chunks +16 lines, -3 lines 0 comments Download
M ipc/attachment_broker_privileged.cc View 3 chunks +31 lines, -7 lines 0 comments Download
M ipc/attachment_broker_privileged_mac.cc View 1 2 3 4 chunks +11 lines, -5 lines 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 39 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739203004/1
4 years, 10 months ago (2016-02-27 02:40:39 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/180937)
4 years, 10 months ago (2016-02-27 03:19:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739203004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739203004/20001
4 years, 9 months ago (2016-02-29 05:20:05 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/181153)
4 years, 9 months ago (2016-02-29 06:04:04 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739203004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739203004/40001
4 years, 9 months ago (2016-02-29 17:45:02 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 19:22:16 UTC) #12
erikchen
tsepez: Please review.
4 years, 9 months ago (2016-03-16 21:45:11 UTC) #19
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-16 22:16:23 UTC) #20
erikchen
avi: Please review content/
4 years, 9 months ago (2016-03-16 22:23:12 UTC) #22
erikchen
sergeyu: Please review.
4 years, 9 months ago (2016-03-16 23:47:02 UTC) #24
Avi (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-17 02:22:45 UTC) #25
Sergey Ulanov
https://codereview.chromium.org/1739203004/diff/40001/remoting/host/win/wts_session_process_delegate.cc File remoting/host/win/wts_session_process_delegate.cc (right): https://codereview.chromium.org/1739203004/diff/40001/remoting/host/win/wts_session_process_delegate.cc#newcode430 remoting/host/win/wts_session_process_delegate.cc:430: channel_.get(), caller_task_runner_); the channel_ is initialized with io_task_runner_ above. ...
4 years, 9 months ago (2016-03-17 23:41:56 UTC) #26
erikchen
https://codereview.chromium.org/1739203004/diff/40001/remoting/host/win/wts_session_process_delegate.cc File remoting/host/win/wts_session_process_delegate.cc (right): https://codereview.chromium.org/1739203004/diff/40001/remoting/host/win/wts_session_process_delegate.cc#newcode430 remoting/host/win/wts_session_process_delegate.cc:430: channel_.get(), caller_task_runner_); On 2016/03/17 23:41:56, Sergey Ulanov wrote: > ...
4 years, 9 months ago (2016-03-19 00:52:46 UTC) #27
Sergey Ulanov
lgtm
4 years, 9 months ago (2016-03-21 19:58:53 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739203004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739203004/80001
4 years, 9 months ago (2016-03-21 21:57:38 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739203004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739203004/80001
4 years, 9 months ago (2016-03-21 22:30:52 UTC) #35
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-21 23:19:49 UTC) #37
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 23:21:04 UTC) #39
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a91d0513fa16b2e8c48acbaf7a5c18659ab10d07
Cr-Commit-Position: refs/heads/master@{#382431}

Powered by Google App Engine
This is Rietveld 408576698