Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 "+components/webdata/common", | 2 "+components/webdata/common", |
| 3 "+content/public/browser", | |
| 4 "+content/public/common", | |
| 5 "+crypto/random.h", | 3 "+crypto/random.h", |
| 6 "+google_apis/gaia", | 4 "+google_apis/gaia", |
| 7 "+google_apis/google_api_keys.h", | 5 "+google_apis/google_api_keys.h", |
| 8 "+gpu/config/gpu_info.h", | |
| 9 "+net", | 6 "+net", |
| 10 "+sql", | 7 "+sql", |
| 11 "+third_party/libjingle", | 8 "+third_party/libjingle", |
| 12 "+third_party/libphonenumber", # For phone number i18n. | 9 "+third_party/libphonenumber", # For phone number i18n. |
| 13 # Allow inclusion of WebKit API files. | |
| 14 "+third_party/WebKit/public/platform", | |
| 15 "+third_party/WebKit/Source/WebKit/chromium", | |
| 16 "+webkit/plugins/webplugininfo.h", | |
| 17 | 10 |
| 11 # TODO(blundell): Bring this list to zero. | |
| 12 # | |
| 13 # Do not add to the list of temporarily-allowed dependencies below, | |
| 14 # and please do not introduce more #includes of these files. | |
| 15 "!content/public/browser/android/content_view_core.h", | |
| 16 "!content/public/browser/browser_context.h", | |
| 17 "!content/public/browser/browser_thread.h", | |
| 18 "!content/public/browser/navigation_controller.h", | |
| 19 "!content/public/browser/navigation_details.h", | |
| 20 "!content/public/browser/notification_details.h", | |
| 21 "!content/public/browser/notification_observer.h", | |
| 22 "!content/public/browser/notification_registrar.h", | |
| 23 "!content/public/browser/notification_service.h", | |
| 24 "!content/public/browser/notification_source.h", | |
| 25 "!content/public/browser/notification_types.h", | |
| 26 "!content/public/browser/render_view_host.h", | |
| 27 "!content/public/browser/web_contents.h", | |
| 28 "!content/public/browser/web_contents_observer.h", | |
| 29 "!content/public/browser/web_contents_view.h", | |
| 30 "!content/public/common/frame_navigate_params.h", | |
| 31 "!content/public/common/url_constants.h", | |
| 32 "!third_party/WebKit/Source/WebKit/chromium/public/WebAutofillClient.h", | |
| 33 "!third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h", | |
| 34 | |
| 18 # TODO(joi): This is "ok" temporarily (it's just a header file with | 35 # TODO(joi): This is "ok" temporarily (it's just a header file with |
| 19 # a large enum, and doesn't bring in any other dependencies on | 36 # a large enum, and doesn't bring in any other dependencies on |
| 20 # //chrome). The plan of record to get rid of this is to change | 37 # //chrome). The plan of record to get rid of this is to change |
| 21 # Autofill and WebData to not use NotificationService, and instead | 38 # Autofill and WebData to not use NotificationService, and instead |
| 22 # use typed callback interfaces or allow registering base::Callback | 39 # use typed callback interfaces or allow registering base::Callback |
| 23 # callbacks for each event. | 40 # callbacks for each event. |
| 24 "!chrome/common/chrome_notification_types.h", | 41 "!chrome/common/chrome_notification_types.h", |
| 25 | 42 |
| 26 # TODO(akalin): Remove this dependency. | 43 # TODO(akalin): Remove this dependency. |
| 27 "!sync/util/data_encryption_win.h", | 44 "!sync/util/data_encryption_win.h", |
| 28 ] | 45 ] |
| 29 | 46 |
| 30 specific_include_rules = { | 47 specific_include_rules = { |
| 31 '.*_[a-z]*test\.cc': [ | 48 '.*_[a-z]*test\.cc': [ |
| 32 "+content/public/test", | 49 "+content/public/test", |
| 33 | 50 |
| 34 # TODO(joi, kaiwang): Bring this list to zero. | 51 # TODO(joi, kaiwang): Bring this list to zero. |
|
Jói
2013/06/18 22:14:28
-kaiwang from the TODO
I think this had been done
blundell
2013/06/18 22:40:11
Done.
| |
| 35 # | 52 # |
| 36 # Do not add to the list of temporarily-allowed dependencies below, | 53 # Do not add to the list of temporarily-allowed dependencies below, |
| 37 # and please do not introduce more #includes of these files. | 54 # and please do not introduce more #includes of these files. |
| 38 "!chrome/browser/autofill/autofill_cc_infobar_delegate.h", | 55 "!chrome/browser/autofill/autofill_cc_infobar_delegate.h", |
| 39 "!chrome/browser/autofill/personal_data_manager_factory.h", | 56 "!chrome/browser/autofill/personal_data_manager_factory.h", |
| 40 "!chrome/browser/password_manager/encryptor.h", | 57 "!chrome/browser/password_manager/encryptor.h", |
| 41 "!chrome/browser/password_manager/password_manager.h", | 58 "!chrome/browser/password_manager/password_manager.h", |
| 42 "!chrome/browser/password_manager/password_manager_delegate_impl.h", | 59 "!chrome/browser/password_manager/password_manager_delegate_impl.h", |
| 43 "!chrome/browser/profiles/profile.h", | 60 "!chrome/browser/profiles/profile.h", |
| 44 "!chrome/browser/sync/profile_sync_service.h", | 61 "!chrome/browser/sync/profile_sync_service.h", |
| 45 "!chrome/browser/sync/profile_sync_service_factory.h", | 62 "!chrome/browser/sync/profile_sync_service_factory.h", |
| 46 "!chrome/browser/translate/translate_infobar_delegate.h", | 63 "!chrome/browser/translate/translate_infobar_delegate.h", |
| 47 "!chrome/browser/translate/translate_manager.h", | 64 "!chrome/browser/translate/translate_manager.h", |
| 48 "!chrome/browser/ui/autofill/tab_autofill_manager_delegate.h", | 65 "!chrome/browser/ui/autofill/tab_autofill_manager_delegate.h", |
| 49 "!chrome/browser/ui/browser.h", | 66 "!chrome/browser/ui/browser.h", |
| 50 "!chrome/browser/ui/browser_tabstrip.h", | 67 "!chrome/browser/ui/browser_tabstrip.h", |
| 51 "!chrome/browser/ui/browser_window.h", | 68 "!chrome/browser/ui/browser_window.h", |
| 52 "!chrome/browser/ui/tabs/tab_strip_model.h", | 69 "!chrome/browser/ui/tabs/tab_strip_model.h", |
| 53 "!chrome/browser/webdata/web_data_service.h", | 70 "!chrome/browser/webdata/web_data_service.h", |
| 54 "!chrome/browser/webdata/web_data_service_factory.h", | 71 "!chrome/browser/webdata/web_data_service_factory.h", |
| 55 "!chrome/browser/webdata/web_data_service_test_util.h", | 72 "!chrome/browser/webdata/web_data_service_test_util.h", |
| 56 "!chrome/common/chrome_constants.h", | 73 "!chrome/common/chrome_constants.h", |
| 57 "!chrome/common/chrome_paths.h", | 74 "!chrome/common/chrome_paths.h", |
| 58 "!chrome/common/pref_names.h", | 75 "!chrome/common/pref_names.h", |
| 59 "!chrome/common/render_messages.h", | 76 "!chrome/common/render_messages.h", |
| 60 "!chrome/common/url_constants.h", | 77 "!chrome/common/url_constants.h", |
| 61 "!chrome/test/base", | 78 "!chrome/test/base", |
| 62 ], | 79 ], |
| 63 } | 80 } |
| OLD | NEW |