Issue 17392: Make resource_bundle compile on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17392: Make resource_bundle compile on Linux. (Closed)

Created:
11 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, Dean McNamee, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make resource_bundle compile on Linux. It's still missing implementations of many functions, but those will be easier to implement once we have the data file generation working, which Tony has underway.

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -2 lines)			Patch
M	chrome/common/common.scons	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/gfx/chrome_font.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/gfx/chrome_font_skia.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/resource_bundle.h	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	chrome/common/resource_bundle.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/17392/diff/1/5 File chrome/common/resource_bundle.cc (right): http://codereview.chromium.org/17392/diff/1/5#newcode7 Line 7: #if defined(OS_WIN) Tears. Maybe we should try ...

11 years, 11 months ago (2009-01-13 21:33:27 UTC) #2

Dean McNamee

http://codereview.chromium.org/17392/diff/1/6 File chrome/common/resource_bundle.h (right): http://codereview.chromium.org/17392/diff/1/6#newcode22 Line 22: #if defined(OS_LINUX) I don't see why this should ...

11 years, 11 months ago (2009-01-14 11:28:02 UTC) #3

Evan Martin

11 years, 11 months ago (2009-01-14 18:00:02 UTC) #4

On 2009/01/14 11:28:02, Dean McNamee wrote:
> http://codereview.chromium.org/17392/diff/1/6#newcode22
> Line 22: #if defined(OS_LINUX)
> I don't see why this should have to be ifdef'd, it's just a forward
declaration,
> it should work everywhere?

Yeah, I guess so.  The code isn't even compiled in on Windows though, so it
might be confusing to someone else who reads this and thinks this code depends
on it.

Expand Messages | Collapse Messages