Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

extensions/common/manifest_handler_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
 
 #include "base/files/file_path.h"
@@ skipping 168 matching lines @@
   (new TestManifestHandler("C.EZ", keys, prereqs, &watcher))->Register();
   prereqs.clear();
   prereqs.push_back("b");
   prereqs.push_back("k");
   (new TestManifestHandler("C.D", SingleKey("c.d"), prereqs, &watcher))->
       Register();
   ManifestHandler::FinalizeRegistration();
 
   scoped_refptr<Extension> extension =
       ExtensionBuilder()
-          .SetManifest(std::move(
-              DictionaryBuilder()
-                  .Set("name", "no name")
-                  .Set("version", "0")
-                  .Set("manifest_version", 2)
-                  .Set("a", 1)
-                  .Set("b", 2)
-                  .Set("c", std::move(
-                                DictionaryBuilder().Set("d", 3).Set("e", 4).Set(
-                                    "f", 5)))
-                  .Set("g", 6)))
+          .SetManifest(DictionaryBuilder()
+                           .Set("name", "no name")
+                           .Set("version", "0")
+                           .Set("manifest_version", 2)
+                           .Set("a", 1)
+                           .Set("b", 2)
+                           .Set("c", DictionaryBuilder()
+                                         .Set("d", 3)
+                                         .Set("e", 4)
+                                         .Set("f", 5)
+                                         .Build())
+                           .Set("g", 6)
+                           .Build())
           .Build();
 
   // A, B, C.EZ, C.D, K
   EXPECT_EQ(5u, watcher.parsed_names().size());
   EXPECT_TRUE(watcher.ParsedBefore("B", "C.D"));
   EXPECT_TRUE(watcher.ParsedBefore("K", "C.D"));
   EXPECT_TRUE(watcher.ParsedBefore("C.D", "C.EZ"));
 }
 
 TEST_F(ManifestHandlerTest, FailingHandlers) {
@@ skipping 31 matching lines @@
       Extension::NO_FLAGS,
       &error);
   EXPECT_FALSE(extension.get());
   EXPECT_EQ("A", error);
 }
 
 TEST_F(ManifestHandlerTest, Validate) {
   ScopedTestingManifestHandlerRegistry registry;
   scoped_refptr<Extension> extension =
       ExtensionBuilder()
-          .SetManifest(std::move(DictionaryBuilder()
-                                     .Set("name", "no name")
-                                     .Set("version", "0")
-                                     .Set("manifest_version", 2)
-                                     .Set("a", 1)
-                                     .Set("b", 2)))
+          .SetManifest(DictionaryBuilder()
+                           .Set("name", "no name")
+                           .Set("version", "0")
+                           .Set("manifest_version", 2)
+                           .Set("a", 1)
+                           .Set("b", 2)
+                           .Build())
           .Build();
   EXPECT_TRUE(extension.get());
 
   std::string error;
   std::vector<InstallWarning> warnings;
   // Always validates and fails.
   (new TestManifestValidator(false, true, SingleKey("c")))->Register();
   EXPECT_FALSE(
       ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));
 
   // This overrides the registered handler for "c".
   (new TestManifestValidator(false, false, SingleKey("c")))->Register();
   EXPECT_TRUE(
       ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));
 
   // Validates "a" and fails.
   (new TestManifestValidator(false, true, SingleKey("a")))->Register();
   EXPECT_FALSE(
       ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));
 }
 
 }  // namespace extensions