Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: extensions/common/extension_builder.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/extension_builder.h" 5 #include "extensions/common/extension_builder.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "extensions/common/extension.h" 9 #include "extensions/common/extension.h"
10 10
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 location_ = location; 54 location_ = location;
55 return *this; 55 return *this;
56 } 56 }
57 57
58 ExtensionBuilder& ExtensionBuilder::SetManifest( 58 ExtensionBuilder& ExtensionBuilder::SetManifest(
59 scoped_ptr<base::DictionaryValue> manifest) { 59 scoped_ptr<base::DictionaryValue> manifest) {
60 manifest_ = std::move(manifest); 60 manifest_ = std::move(manifest);
61 return *this; 61 return *this;
62 } 62 }
63 63
64 ExtensionBuilder& ExtensionBuilder::MergeManifest(DictionaryBuilder& builder) { 64 ExtensionBuilder& ExtensionBuilder::MergeManifest(
65 manifest_->MergeDictionary(builder.Build().get()); 65 scoped_ptr<base::DictionaryValue> manifest) {
66 manifest_->MergeDictionary(manifest.get());
66 return *this; 67 return *this;
67 } 68 }
68 69
69 ExtensionBuilder& ExtensionBuilder::AddFlags(int init_from_value_flags) { 70 ExtensionBuilder& ExtensionBuilder::AddFlags(int init_from_value_flags) {
70 flags_ |= init_from_value_flags; 71 flags_ |= init_from_value_flags;
71 return *this; 72 return *this;
72 } 73 }
73 74
74 ExtensionBuilder& ExtensionBuilder::SetID(const std::string& id) { 75 ExtensionBuilder& ExtensionBuilder::SetID(const std::string& id) {
75 id_ = id; 76 id_ = id;
76 return *this; 77 return *this;
77 } 78 }
78 79
79 } // namespace extensions 80 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698