Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "chrome/browser/media/router/media_route.h" 6 #include "chrome/browser/media/router/media_route.h"
7 #include "chrome/browser/media/router/mock_media_router.h" 7 #include "chrome/browser/media/router/mock_media_router.h"
8 #include "chrome/browser/media/router/route_request_result.h" 8 #include "chrome/browser/media/router/route_request_result.h"
9 #include "chrome/browser/ui/webui/media_router/media_router_ui.h" 9 #include "chrome/browser/ui/webui/media_router/media_router_ui.h"
10 #include "chrome/browser/ui/webui/media_router/media_router_webui_message_handle r.h" 10 #include "chrome/browser/ui/webui/media_router/media_router_webui_message_handle r.h"
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 observer.reset(); 234 observer.reset();
235 } 235 }
236 236
237 TEST_F(MediaRouterUITest, GetExtensionNameExtensionPresent) { 237 TEST_F(MediaRouterUITest, GetExtensionNameExtensionPresent) {
238 std::string id = "extensionid"; 238 std::string id = "extensionid";
239 GURL url = GURL("chrome-extension://" + id); 239 GURL url = GURL("chrome-extension://" + id);
240 scoped_ptr<extensions::ExtensionRegistry> registry = 240 scoped_ptr<extensions::ExtensionRegistry> registry =
241 make_scoped_ptr(new extensions::ExtensionRegistry(nullptr)); 241 make_scoped_ptr(new extensions::ExtensionRegistry(nullptr));
242 scoped_refptr<extensions::Extension> app = 242 scoped_refptr<extensions::Extension> app =
243 extensions::test_util::BuildApp(extensions::ExtensionBuilder()) 243 extensions::test_util::BuildApp(extensions::ExtensionBuilder())
244 .MergeManifest( 244 .MergeManifest(extensions::DictionaryBuilder()
245 extensions::DictionaryBuilder().Set("name", "test app name")) 245 .Set("name", "test app name")
246 .Build())
246 .SetID(id) 247 .SetID(id)
247 .Build(); 248 .Build();
248 249
249 ASSERT_TRUE(registry->AddEnabled(app)); 250 ASSERT_TRUE(registry->AddEnabled(app));
250 EXPECT_EQ("test app name", 251 EXPECT_EQ("test app name",
251 MediaRouterUI::GetExtensionName(url, registry.get())); 252 MediaRouterUI::GetExtensionName(url, registry.get()));
252 } 253 }
253 254
254 TEST_F(MediaRouterUITest, GetExtensionNameEmptyWhenNotInstalled) { 255 TEST_F(MediaRouterUITest, GetExtensionNameEmptyWhenNotInstalled) {
255 std::string id = "extensionid"; 256 std::string id = "extensionid";
256 GURL url = GURL("chrome-extension://" + id); 257 GURL url = GURL("chrome-extension://" + id);
257 scoped_ptr<extensions::ExtensionRegistry> registry = 258 scoped_ptr<extensions::ExtensionRegistry> registry =
258 make_scoped_ptr(new extensions::ExtensionRegistry(nullptr)); 259 make_scoped_ptr(new extensions::ExtensionRegistry(nullptr));
259 260
260 EXPECT_EQ("", MediaRouterUI::GetExtensionName(url, registry.get())); 261 EXPECT_EQ("", MediaRouterUI::GetExtensionName(url, registry.get()));
261 } 262 }
262 263
263 TEST_F(MediaRouterUITest, GetExtensionNameEmptyWhenNotExtensionURL) { 264 TEST_F(MediaRouterUITest, GetExtensionNameEmptyWhenNotExtensionURL) {
264 GURL url = GURL("https://www.google.com"); 265 GURL url = GURL("https://www.google.com");
265 scoped_ptr<extensions::ExtensionRegistry> registry = 266 scoped_ptr<extensions::ExtensionRegistry> registry =
266 make_scoped_ptr(new extensions::ExtensionRegistry(nullptr)); 267 make_scoped_ptr(new extensions::ExtensionRegistry(nullptr));
267 268
268 EXPECT_EQ("", MediaRouterUI::GetExtensionName(url, registry.get())); 269 EXPECT_EQ("", MediaRouterUI::GetExtensionName(url, registry.get()));
269 } 270 }
270 } // namespace media_router 271 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698