Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/declarative_content/declarative_content_ is_bookmarked_condition_tracker.h" 5 #include "chrome/browser/extensions/api/declarative_content/declarative_content_ is_bookmarked_condition_tracker.h"
6 6
7 #include <set> 7 #include <set>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 21 matching lines...) Expand all
32 32
33 namespace { 33 namespace {
34 34
35 scoped_refptr<Extension> CreateExtensionWithBookmarksPermission( 35 scoped_refptr<Extension> CreateExtensionWithBookmarksPermission(
36 bool include_bookmarks) { 36 bool include_bookmarks) {
37 ListBuilder permissions; 37 ListBuilder permissions;
38 permissions.Append("declarativeContent"); 38 permissions.Append("declarativeContent");
39 if (include_bookmarks) 39 if (include_bookmarks)
40 permissions.Append("bookmarks"); 40 permissions.Append("bookmarks");
41 return ExtensionBuilder() 41 return ExtensionBuilder()
42 .SetManifest(std::move(DictionaryBuilder() 42 .SetManifest(DictionaryBuilder()
43 .Set("name", "Test extension") 43 .Set("name", "Test extension")
44 .Set("version", "1.0") 44 .Set("version", "1.0")
45 .Set("manifest_version", 2) 45 .Set("manifest_version", 2)
46 .Set("permissions", std::move(permissions)))) 46 .Set("permissions", permissions.Build())
47 .Build())
47 .Build(); 48 .Build();
48 } 49 }
49 50
50 scoped_ptr<DeclarativeContentIsBookmarkedPredicate> CreatePredicate( 51 scoped_ptr<DeclarativeContentIsBookmarkedPredicate> CreatePredicate(
51 ContentPredicateEvaluator* evaluator, 52 ContentPredicateEvaluator* evaluator,
52 const Extension* extension, 53 const Extension* extension,
53 bool is_bookmarked) { 54 bool is_bookmarked) {
54 std::string error; 55 std::string error;
55 scoped_ptr<DeclarativeContentIsBookmarkedPredicate> predicate = 56 scoped_ptr<DeclarativeContentIsBookmarkedPredicate> predicate =
56 DeclarativeContentIsBookmarkedPredicate::Create( 57 DeclarativeContentIsBookmarkedPredicate::Create(
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 tracker_->OnWebContentsNavigation(tabs[0].get(), 433 tracker_->OnWebContentsNavigation(tabs[0].get(),
433 content::LoadCommittedDetails(), 434 content::LoadCommittedDetails(),
434 content::FrameNavigateParams()); 435 content::FrameNavigateParams());
435 EXPECT_THAT(delegate_.evaluation_requests(), 436 EXPECT_THAT(delegate_.evaluation_requests(),
436 UnorderedElementsAre(tabs[0].get())); 437 UnorderedElementsAre(tabs[0].get()));
437 EXPECT_TRUE(CheckPredicates(tabs[0].get(), false)); 438 EXPECT_TRUE(CheckPredicates(tabs[0].get(), false));
438 EXPECT_TRUE(CheckPredicates(tabs[1].get(), false)); 439 EXPECT_TRUE(CheckPredicates(tabs[1].get(), false));
439 } 440 }
440 441
441 } // namespace extensions 442 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698