Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/printer_detector/printer_detector.h"
 
 #include <stdint.h>
 
 #include <utility>
 
@@ skipping 111 matching lines @@
                       uint16_t product_id,
                       uint8_t interface_class) {
     device::UsbConfigDescriptor config(1, false, false, 0);
     config.interfaces.emplace_back(1, 0, interface_class, 0, 0);
     usb_service_.AddDevice(
         new device::MockUsbDevice(vendor_id, product_id, config));
   }
 
   // Creates a test extension with the provided permissions.
   scoped_refptr<extensions::Extension> CreateTestExtension(
-      ListBuilder permissions_builder,
-      DictionaryBuilder usb_printers_builder) {
+      scoped_ptr<base::ListValue> permissions_builder,
+      scoped_ptr<base::DictionaryValue> usb_printers_builder) {
     return extensions::ExtensionBuilder()
         .SetID("fake_extension_id")
-        .SetManifest(std::move(
+        .SetManifest(
             DictionaryBuilder()
                 .Set("name", "Printer provider extension")
                 .Set("manifest_version", 2)
                 .Set("version", "1.0")
                 // Needed to enable usb API.
-                .Set("app", std::move(DictionaryBuilder().Set(
-                                "background",
-                                std::move(DictionaryBuilder().Set(
-                                    "scripts", std::move(ListBuilder().Append(
-                                                   "bg.js")))))))
+                .Set("app",
+                     DictionaryBuilder()
+                         .Set("background",
+                              DictionaryBuilder()
+                                  .Set("scripts",
+                                       ListBuilder().Append("bg.js").Build())
+                                  .Build())
+                         .Build())
                 .Set("permissions", std::move(permissions_builder))
-                .Set("usb_printers", std::move(usb_printers_builder))))
+                .Set("usb_printers", std::move(usb_printers_builder))
+                .Build())
         .Build();
   }
 
   content::TestBrowserThreadBundle thread_bundle_;
   StubNotificationUIManager notification_ui_manager_;
   user_manager::FakeUserManager* user_manager_;
   chromeos::ScopedUserManagerEnabler user_manager_enabler_;
   device::MockUsbService usb_service_;
   scoped_ptr<TestingProfile> profile_;
   FakeDeviceClient device_client_;
 
   DISALLOW_COPY_AND_ASSIGN(PrinterDetectorAppSearchEnabledTest);
 };
 
 TEST_F(PrinterDetectorAppSearchEnabledTest, ShowFindAppNotification) {
   InvokeUsbAdded(123, 456, kPrinterInterfaceClass);
 
   ASSERT_EQ(1u, notification_ui_manager_.GetNotificationCount());
   const Notification& notification =
       notification_ui_manager_.GetNotificationAt(0);
   EXPECT_EQ("123:456", notification.tag());
   EXPECT_EQ(
       base::StringPrintf(kPrinterAppNotFoundDelegateIDTemplate, "123", "456"),
       notification.delegate_id());
 }
 
 TEST_F(PrinterDetectorAppSearchEnabledTest, ShowAppFoundNotification) {
   scoped_refptr<extensions::Extension> extension = CreateTestExtension(
-      std::move(ListBuilder()
-                    .Append("usb")
-                    .Append("printerProvider")
-                    .Append(std::move(DictionaryBuilder().Set(
-                        "usbDevices", std::move(ListBuilder().Append(std::move(
-                                          DictionaryBuilder()
-                                              .Set("vendorId", 123)
-                                              .Set("productId", 456)))))))),
-      std::move(DictionaryBuilder().Set("filters", ListBuilder())));
+      ListBuilder()
+          .Append("usb")
+          .Append("printerProvider")
+          .Append(DictionaryBuilder()
+                      .Set("usbDevices", ListBuilder()
+                                             .Append(DictionaryBuilder()
+                                                         .Set("vendorId", 123)
+                                                         .Set("productId", 456)
+                                                         .Build())
+                                             .Build())
+                      .Build())
+          .Build(),
+      DictionaryBuilder().Set("filters", ListBuilder().Build()).Build());
   ASSERT_TRUE(extensions::ExtensionRegistry::Get(profile_.get())
                   ->AddEnabled(extension));
 
   InvokeUsbAdded(123, 456, kPrinterInterfaceClass);
 
   ASSERT_EQ(1u, notification_ui_manager_.GetNotificationCount());
   const Notification& notification =
       notification_ui_manager_.GetNotificationAt(0);
   EXPECT_EQ("123:456", notification.tag());
   EXPECT_EQ(
       base::StringPrintf(kPrinterAppExistsDelegateIDTemplate, "123", "456"),
       notification.delegate_id());
 }
 
 TEST_F(PrinterDetectorAppSearchEnabledTest,
        UsbHandlerExists_NotPrinterProvider) {
   scoped_refptr<extensions::Extension> extension = CreateTestExtension(
-      std::move(
-          ListBuilder().Append("usb").Append(std::move(DictionaryBuilder().Set(
-              "usbDevices", std::move(ListBuilder().Append(
-                                std::move(DictionaryBuilder()
-                                              .Set("vendorId", 123)
-                                              .Set("productId", 756)))))))),
-      std::move(DictionaryBuilder().Set("filters", ListBuilder())));
+      ListBuilder()
+          .Append("usb")
+          .Append(DictionaryBuilder()
+                      .Set("usbDevices", ListBuilder()
+                                             .Append(DictionaryBuilder()
+                                                         .Set("vendorId", 123)
+                                                         .Set("productId", 756)
+                                                         .Build())
+                                             .Build())
+                      .Build())
+          .Build(),
+      DictionaryBuilder().Set("filters", ListBuilder().Build()).Build());
   ASSERT_TRUE(extensions::ExtensionRegistry::Get(profile_.get())
                   ->AddEnabled(extension));
 
   InvokeUsbAdded(123, 756, kPrinterInterfaceClass);
 
   ASSERT_EQ(1u, notification_ui_manager_.GetNotificationCount());
   const Notification& notification =
       notification_ui_manager_.GetNotificationAt(0);
   EXPECT_EQ("123:756", notification.tag());
   EXPECT_EQ(
       base::StringPrintf(kPrinterAppNotFoundDelegateIDTemplate, "123", "756"),
       notification.delegate_id());
 }
 
 TEST_F(PrinterDetectorAppSearchEnabledTest,
        PrinterProvider_DifferentUsbProductId) {
   scoped_refptr<extensions::Extension> extension = CreateTestExtension(
-      std::move(ListBuilder()
-                    .Append("usb")
-                    .Append("printerProvider")
-                    .Append(std::move(DictionaryBuilder().Set(
-                        "usbDevices", std::move(ListBuilder().Append(std::move(
-                                          DictionaryBuilder()
-                                              .Set("vendorId", 123)
-                                              .Set("productId", 001)))))))),
-      std::move(DictionaryBuilder().Set("filters", ListBuilder())));
+      ListBuilder()
+          .Append("usb")
+          .Append("printerProvider")
+          .Append(DictionaryBuilder()
+                      .Set("usbDevices", ListBuilder()
+                                             .Append(DictionaryBuilder()
+                                                         .Set("vendorId", 123)
+                                                         .Set("productId", 001)
+                                                         .Build())
+                                             .Build())
+                      .Build())
+          .Build(),
+      DictionaryBuilder().Set("filters", ListBuilder().Build()).Build());
   ASSERT_TRUE(extensions::ExtensionRegistry::Get(profile_.get())
                   ->AddEnabled(extension));
 
   InvokeUsbAdded(123, 456, kPrinterInterfaceClass);
 
   ASSERT_EQ(1u, notification_ui_manager_.GetNotificationCount());
   const Notification& notification =
       notification_ui_manager_.GetNotificationAt(0);
   EXPECT_EQ("123:456", notification.tag());
   EXPECT_EQ(
       base::StringPrintf(kPrinterAppNotFoundDelegateIDTemplate, "123", "456"),
       notification.delegate_id());
 }
 
 TEST_F(PrinterDetectorAppSearchEnabledTest,
        PrinterProvider_UsbPrinters_NotFound) {
   scoped_refptr<extensions::Extension> extension = CreateTestExtension(
-      std::move(ListBuilder().Append("usb").Append("printerProvider")),
-      std::move(DictionaryBuilder().Set(
-          "filters", std::move(ListBuilder().Append(
-                         std::move(DictionaryBuilder()
-                                       .Set("vendorId", 123)
-                                       .Set("productId", 001)))))));
+      ListBuilder().Append("usb").Append("printerProvider").Build(),
+      DictionaryBuilder()
+          .Set("filters", ListBuilder()
+                              .Append(DictionaryBuilder()
+                                          .Set("vendorId", 123)
+                                          .Set("productId", 001)
+                                          .Build())
+                              .Build())
+          .Build());
   ASSERT_TRUE(extensions::ExtensionRegistry::Get(profile_.get())
                   ->AddEnabled(extension));
 
   InvokeUsbAdded(123, 456, kPrinterInterfaceClass);
 
   ASSERT_EQ(1u, notification_ui_manager_.GetNotificationCount());
   const Notification& notification =
       notification_ui_manager_.GetNotificationAt(0);
   EXPECT_EQ("123:456", notification.tag());
   EXPECT_EQ(
       base::StringPrintf(kPrinterAppNotFoundDelegateIDTemplate, "123", "456"),
       notification.delegate_id());
 }
 
 TEST_F(PrinterDetectorAppSearchEnabledTest,
        PrinterProvider_UsbPrinters_WithProductId) {
   scoped_refptr<extensions::Extension> extension = CreateTestExtension(
-      std::move(ListBuilder().Append("usb").Append("printerProvider")),
-      std::move(DictionaryBuilder().Set(
-          "filters", std::move(ListBuilder().Append(
-                         std::move(DictionaryBuilder()
-                                       .Set("vendorId", 123)
-                                       .Set("productId", 456)))))));
+      ListBuilder().Append("usb").Append("printerProvider").Build(),
+      DictionaryBuilder()
+          .Set("filters", ListBuilder()
+                              .Append(DictionaryBuilder()
+                                          .Set("vendorId", 123)
+                                          .Set("productId", 456)
+                                          .Build())
+                              .Build())
+          .Build());
   ASSERT_TRUE(extensions::ExtensionRegistry::Get(profile_.get())
                   ->AddEnabled(extension));
 
   InvokeUsbAdded(123, 456, kPrinterInterfaceClass);
 
   ASSERT_EQ(1u, notification_ui_manager_.GetNotificationCount());
   const Notification& notification =
       notification_ui_manager_.GetNotificationAt(0);
   EXPECT_EQ("123:456", notification.tag());
   EXPECT_EQ(
       base::StringPrintf(kPrinterAppExistsDelegateIDTemplate, "123", "456"),
       notification.delegate_id());
 }
 
 TEST_F(PrinterDetectorAppSearchEnabledTest,
        PrinterProvider_UsbPrinters_WithInterfaceClass) {
   scoped_refptr<extensions::Extension> extension = CreateTestExtension(
-      std::move(ListBuilder().Append("usb").Append("printerProvider")),
-      std::move(DictionaryBuilder().Set(
-          "filters",
-          std::move(ListBuilder().Append(std::move(
-              DictionaryBuilder()
-                  .Set("vendorId", 123)
-                  .Set("interfaceClass", kPrinterInterfaceClass)))))));
+      ListBuilder().Append("usb").Append("printerProvider").Build(),
+      DictionaryBuilder()
+          .Set("filters",
+               ListBuilder()
+                   .Append(DictionaryBuilder()
+                               .Set("vendorId", 123)
+                               .Set("interfaceClass", kPrinterInterfaceClass)
+                               .Build())
+                   .Build())
+          .Build());
   ASSERT_TRUE(extensions::ExtensionRegistry::Get(profile_.get())
                   ->AddEnabled(extension));
 
   InvokeUsbAdded(123, 456, kPrinterInterfaceClass);
 
   ASSERT_EQ(1u, notification_ui_manager_.GetNotificationCount());
   const Notification& notification =
       notification_ui_manager_.GetNotificationAt(0);
   EXPECT_EQ("123:456", notification.tag());
   EXPECT_EQ(
       base::StringPrintf(kPrinterAppExistsDelegateIDTemplate, "123", "456"),
       notification.delegate_id());
 }
 
 TEST_F(PrinterDetectorAppSearchEnabledTest, IgnoreNonPrinters) {
   scoped_refptr<extensions::Extension> extension = CreateTestExtension(
-      std::move(ListBuilder().Append("usb").Append("printerProvider")),
-      std::move(DictionaryBuilder().Set(
-          "filters",
-          std::move(ListBuilder().Append(std::move(
-              DictionaryBuilder()
-                  .Set("vendorId", 123)
-                  .Set("interfaceClass", kPrinterInterfaceClass)))))));
+      ListBuilder().Append("usb").Append("printerProvider").Build(),
+      DictionaryBuilder()
+          .Set("filters",
+               ListBuilder()
+                   .Append(DictionaryBuilder()
+                               .Set("vendorId", 123)
+                               .Set("interfaceClass", kPrinterInterfaceClass)
+                               .Build())
+                   .Build())
+          .Build());
   ASSERT_TRUE(extensions::ExtensionRegistry::Get(profile_.get())
                   ->AddEnabled(extension));
 
   InvokeUsbAdded(123, 456, 1);
 
   ASSERT_EQ(0u, notification_ui_manager_.GetNotificationCount());
 }
 
 }  // namespace chromeos