Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1739183002: DevTools: [CSSP] do not wrap computed properties. (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [CSSP] do not wrap computed properties. BUG=587770 R=pfeldman, dgozman Committed: https://crrev.com/472b66e620c090e3fe5d7a725ee684b046a61280 Cr-Commit-Position: refs/heads/master@{#378020}

Patch Set 1 #

Patch Set 2 : address comments #

Patch Set 3 : rebaseline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
lushnikov
Ptal. Screenshot: http://i.imgur.com/l9dPAoA.png
4 years, 10 months ago (2016-02-26 02:41:39 UTC) #1
dgozman
lgtm
4 years, 10 months ago (2016-02-26 03:16:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739183002/20001
4 years, 10 months ago (2016-02-26 06:57:21 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/186456)
4 years, 10 months ago (2016-02-26 07:45:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739183002/40001
4 years, 10 months ago (2016-02-26 20:12:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/149657)
4 years, 10 months ago (2016-02-26 20:35:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739183002/40001
4 years, 10 months ago (2016-02-26 21:31:14 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-26 23:18:41 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 23:20:20 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/472b66e620c090e3fe5d7a725ee684b046a61280
Cr-Commit-Position: refs/heads/master@{#378020}

Powered by Google App Engine
This is Rietveld 408576698