Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1739173002: Remove left-over compiler-code from precompiled runtime. (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove left-over compiler-code from precompiled runtime. Only instantiate IR classes in compiled regexp mode. Remove remaining stub generation code. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/944aed203ade88a03fdeb087dc9bcf51e39c179b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M runtime/vm/code_generator.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/regexp_assembler.h View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/regexp_assembler.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years, 10 months ago (2016-02-26 01:56:29 UTC) #2
Florian Schneider
+vegorov
4 years, 10 months ago (2016-02-26 03:12:54 UTC) #4
Vyacheslav Egorov (Google)
lgtm
4 years, 10 months ago (2016-02-26 08:14:13 UTC) #5
Florian Schneider
4 years, 10 months ago (2016-02-26 14:59:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
944aed203ade88a03fdeb087dc9bcf51e39c179b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698