chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java - Issue 1739163005: Java side of purging BookmarkId from offline pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

Issue 1739163005: Java side of purging BookmarkId from offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Java side of offline id changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

index e1ece759d0b886af0b2af40c254968b9d48554d8..6bfd8850303006daac8151032520bc1dca1a9b48 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

@@ -18,8 +18,6 @@ import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.SavePageCallba

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

-import org.chromium.components.bookmarks.BookmarkId;

-import org.chromium.components.bookmarks.BookmarkType;

import org.chromium.components.offlinepages.SavePageResult;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -38,7 +36,8 @@ public class OfflinePageUtilsTest extends ChromeActivityTestCaseBase<ChromeActiv

private static final String TAG = "OfflinePageUtilsTest";

private static final String TEST_PAGE = "/chrome/test/data/android/about.html";

private static final int TIMEOUT_MS = 5000;

- private static final BookmarkId BOOKMARK_ID = new BookmarkId(1234, BookmarkType.NORMAL);

+ private static final ClientId BOOKMARK_ID =

+ new ClientId(OfflinePageBridge.BOOKMARK_NAMESPACE, "1234");

private OfflinePageBridge mOfflinePageBridge;

private EmbeddedTestServer mTestServer;