Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3823)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceDialog.java

Issue 1739163005: Java side of purging BookmarkId from offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Java side of offline id changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceDialog.java
index 4e7aa86c62f7cf5e088c6eb3c7a9691013b3ea42..a611a76da37d3e127d6982fb93581c728af38c2a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceDialog.java
@@ -17,7 +17,6 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.DeletePageCallback;
import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
-import org.chromium.components.bookmarks.BookmarkId;
import java.util.ArrayList;
import java.util.List;
@@ -89,7 +88,7 @@ public class OfflinePageFreeUpSpaceDialog
return;
}
- mOfflinePageBridge.deletePages(getBookmarkIdsToDelete(), new DeletePageCallback() {
+ mOfflinePageBridge.deletePages(getOfflineIdsToDelete(), new DeletePageCallback() {
@Override
public void onDeletePageDone(int deletePageResult) {
RecordUserAction.record("OfflinePages.FreeUpSpaceDialogButtonClicked");
@@ -98,13 +97,13 @@ public class OfflinePageFreeUpSpaceDialog
});
}
- /** Returns a list of Bookmark IDs for which the offline pages will be deleted. */
- private List<BookmarkId> getBookmarkIdsToDelete() {
- List<BookmarkId> bookmarkIds = new ArrayList<BookmarkId>();
+ /** Returns a list of IDs for which the offline pages will be deleted. */
+ private List<Long> getOfflineIdsToDelete() {
+ List<Long> offlineIds = new ArrayList<>();
for (OfflinePageItem offlinePage : mOfflinePagesToDelete) {
- bookmarkIds.add(offlinePage.getBookmarkId());
+ offlineIds.add(offlinePage.getOfflineId());
}
- return bookmarkIds;
+ return offlineIds;
}
/** Returns a total size of offline pages that will be deleted. */

Powered by Google App Engine
This is Rietveld 408576698