chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java - Issue 1739163005: Java side of purging BookmarkId from offline pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java

Issue 1739163005: Java side of purging BookmarkId from offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Java side of offline id changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java

index 9f89b121345bbf99a62457172c70e0d67940dcb7..313fff87082f0b24af123473b16c8b6189cc3eca 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java

@@ -17,6 +17,7 @@ import org.chromium.chrome.R;

import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;

import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkModelObserver;

import org.chromium.chrome.browser.bookmarks.BookmarkPromoHeader.PromoHeaderShowingChangeListener;

+import org.chromium.chrome.browser.offlinepages.ClientId;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.OfflinePageModelObserver;

import org.chromium.chrome.browser.offlinepages.OfflinePageFreeUpSpaceCallback;

@@ -282,9 +283,10 @@ class BookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder>

}

@Override

- public void offlinePageDeleted(BookmarkId bookmarkId) {

+ public void offlinePageDeleted(long offlineId, ClientId clientId) {

if (mDelegate.getCurrentState() == BookmarkUIState.STATE_FILTER) {

- int deletedPosition = getPositionForBookmark(bookmarkId);

+ BookmarkId id = BookmarkModel.getBookmarkIdForOfflineClientId(clientId);

+ int deletedPosition = getPositionForBookmark(id);

if (deletedPosition >= 0) {

removeItem(deletedPosition);

}