Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4236)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java

Issue 1739163005: Java side of purging BookmarkId from offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Java side of offline id changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
index 84d5d996f387c95bb2151bea1bca9a19f4325531..7a17f6fc44207bf3087b514bbeccf753d577f0cd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java
@@ -18,6 +18,7 @@ import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
+import org.chromium.chrome.browser.offlinepages.ClientId;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.offlinepages.OfflinePageItem;
import org.chromium.chrome.browser.widget.RoundedIconGenerator;
@@ -90,7 +91,8 @@ public class BookmarkBookmarkRow extends BookmarkRow implements LargeIconCallbac
OfflinePageItem offlinePage = null;
OfflinePageBridge bridge = mDelegate.getModel().getOfflinePageBridge();
if (mDelegate.getCurrentState() == BookmarkUIState.STATE_FILTER && bridge != null) {
- offlinePage = bridge.getPageByBookmarkId(bookmarkId);
+ offlinePage =
+ bridge.getPageByClientId(ClientId.createClientIdForBookmarkId(bookmarkId));
}
TextView textView = (TextView) findViewById(R.id.offline_page_size);
View bookmarkRowView = findViewById(R.id.bookmark_row);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698