Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp

Issue 1739163004: [Experimental Framework] Only log a console message for each feature once (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-state
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
diff --git a/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp b/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
index 49f79520711011a6de9d383c168fc6e9abb5af63..a0333461279d03ace88e29bb0f24ade9c2c4dac0 100644
--- a/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
+++ b/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
@@ -200,6 +200,38 @@ TEST_F(OriginTrialContextTest, InvalidTokenResponseFromPlatform)
EXPECT_EQ(1, tokenValidator()->callCount());
}
+TEST_F(OriginTrialContextTest, OnlyOneErrorMessageGenerated)
+{
+ String errorMessage1;
+ String errorMessage2;
+ tokenValidator()->setResponse(false);
+ isFeatureEnabled(kFrobulateEnabledOrigin, kFrobulateFeatureName, kGoodToken, &errorMessage1);
+ isFeatureEnabled(kFrobulateEnabledOrigin, kFrobulateFeatureName, kGoodToken, &errorMessage2);
+ EXPECT_FALSE(errorMessage1.isEmpty());
+ EXPECT_TRUE(errorMessage2.isEmpty());
+}
+
+TEST_F(OriginTrialContextTest, ErrorMessageClearedIfStringReused)
+{
+ String errorMessage;
+ tokenValidator()->setResponse(false);
+ isFeatureEnabled(kFrobulateEnabledOrigin, kFrobulateFeatureName, kGoodToken, &errorMessage);
+ EXPECT_FALSE(errorMessage.isEmpty());
+ isFeatureEnabled(kFrobulateEnabledOrigin, kFrobulateFeatureName, kGoodToken, &errorMessage);
+ EXPECT_TRUE(errorMessage.isEmpty());
+}
+
+TEST_F(OriginTrialContextTest, ErrorMessageGeneratedPerFeature)
+{
+ String errorMessage1;
+ String errorMessage2;
+ tokenValidator()->setResponse(false);
+ isFeatureEnabled(kFrobulateEnabledOrigin, kFrobulateFeatureName, kGoodToken, &errorMessage1);
+ isFeatureEnabled(kFrobulateEnabledOrigin, kNonExistingFeatureName, kGoodToken, &errorMessage2);
+ EXPECT_FALSE(errorMessage1.isEmpty());
+ EXPECT_FALSE(errorMessage2.isEmpty());
+}
+
TEST_F(OriginTrialContextTest, EnabledSecureRegisteredOriginWithoutErrorMessage)
{
tokenValidator()->setResponse(true);
« no previous file with comments | « third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698