Revert of Refactoring: Move some classes from content/child to platform

Revert of Refactoring: Move some classes from content/child to platform (patchset #17 id:320001 of https://codereview.chromium.org/1660383002/ )

Reason for revert:
This CL makes perf benchmarks fail on several platforms.

The bisect result:
https://chromeperf.appspot.com/group_report?bug_id=589850

Original issue's description:
> Refactoring: Move some classes from content/child to platform
> 
> This CL moves these classes:
> - WebMemoryAllocatorDumpImpl
> - WebMemoryDumpProviderAdapter
> - WebProcessMemoryDumpImpl(Test)
> from content/child to platform. Now that platform can depend on base,
> we don't need adapter classes in Chromium side.
> 
> After this CL, we will be able to reduce glue classes by unifying:
> - WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl
> - WebProcessMemoryDump and WebProcessMemoryDumpImpl
> - WebMemoryDumpProvider and WebMemoryDumpProviderAdapter
> so that we can reduce lots of code.
> 
> BUG=548254
> 
> Committed: https://crrev.com/a8227af5f6016e10e78b539ffa55aeb634ca7601
> Cr-Commit-Position: refs/heads/master@{#377552}

TBR=tkent@chromium.org,bashi@chromium.org,esprehn@chromium.org,haraken@chromium.org,kinuko@chromium.org,primiano@chromium.org,thakis@chromium.org,xhwang@chromium.org,hajimehoshi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=548254

[Zhen Wang, 2016-02-25 22:31:13]

Created Revert of Refactoring: Move some classes from content/child to platform

[commit-bot: I haz the power, 2016-02-25 22:34:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739113002/1

[commit-bot: I haz the power, 2016-02-25 22:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 22:47:10]

Failed to apply patch for content/child/blink_platform_impl.cc:
While running git apply --index -3 -p1;
  error: patch failed: content/child/blink_platform_impl.cc:485
  Falling back to three-way merge...
  Applied patch to 'content/child/blink_platform_impl.cc' with conflicts.
  U content/child/blink_platform_impl.cc

Patch:       content/child/blink_platform_impl.cc
Index: content/child/blink_platform_impl.cc
diff --git a/content/child/blink_platform_impl.cc
b/content/child/blink_platform_impl.cc
index
7f471e4cf5f58810715db2d8e768c440da6d26ad..8f9c7b16a81400c76363223efbc721d4b3ea0099
100644
--- a/content/child/blink_platform_impl.cc
+++ b/content/child/blink_platform_impl.cc
@@ -50,6 +50,8 @@
 #include "content/child/push_messaging/push_provider.h"
 #include "content/child/thread_safe_sender.h"
 #include "content/child/web_discardable_memory_impl.h"
+#include "content/child/web_memory_dump_provider_adapter.h"
+#include "content/child/web_process_memory_dump_impl.h"
 #include "content/child/web_url_loader_impl.h"
 #include "content/child/web_url_request_util.h"
 #include "content/child/websocket_bridge.h"
@@ -485,6 +487,34 @@
   return static_cast<blink::WebThread*>(current_thread_slot_.Get());
 }
 
+void BlinkPlatformImpl::registerMemoryDumpProvider(
+    blink::WebMemoryDumpProvider* wmdp, const char* name) {
+  WebMemoryDumpProviderAdapter* wmdp_adapter =
+      new WebMemoryDumpProviderAdapter(wmdp);
+  bool did_insert =
+      memory_dump_providers_.add(wmdp, make_scoped_ptr(wmdp_adapter)).second;
+  if (!did_insert)
+    return;
+  wmdp_adapter->set_is_registered(true);
+  base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
+      wmdp_adapter, name, base::ThreadTaskRunnerHandle::Get());
+}
+
+void BlinkPlatformImpl::unregisterMemoryDumpProvider(
+    blink::WebMemoryDumpProvider* wmdp) {
+  scoped_ptr<WebMemoryDumpProviderAdapter> wmdp_adapter =
+      memory_dump_providers_.take_and_erase(wmdp);
+  if (!wmdp_adapter)
+    return;
+  base::trace_event::MemoryDumpManager::GetInstance()->UnregisterDumpProvider(
+      wmdp_adapter.get());
+  wmdp_adapter->set_is_registered(false);
+}
+
+blink::WebProcessMemoryDump* BlinkPlatformImpl::createProcessMemoryDump() {
+  return new WebProcessMemoryDumpImpl();
+}
+
 blink::Platform::WebMemoryAllocatorDumpGuid
 BlinkPlatformImpl::createWebMemoryAllocatorDumpGuid(
     const blink::WebString& guidStr) {

[commit-bot: I haz the power, 2016-02-25 22:56:05]

The CQ bit was unchecked by commit-bot@chromium.org

[Zhen Wang, 2016-02-25 23:07:37]

Description was changed from

==========
Revert of Refactoring: Move some classes from content/child to platform
(patchset #17 id:320001 of https://codereview.chromium.org/1660383002/ )

Reason for revert:
This CL makes perf benchmarks fail on several platforms.

The bisect result:
https://chromeperf.appspot.com/group_report?bug_id=589850

Original issue's description:
> Refactoring: Move some classes from content/child to platform
> 
> This CL moves these classes:
> - WebMemoryAllocatorDumpImpl
> - WebMemoryDumpProviderAdapter
> - WebProcessMemoryDumpImpl(Test)
> from content/child to platform. Now that platform can depend on base,
> we don't need adapter classes in Chromium side.
> 
> After this CL, we will be able to reduce glue classes by unifying:
> - WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl
> - WebProcessMemoryDump and WebProcessMemoryDumpImpl
> - WebMemoryDumpProvider and WebMemoryDumpProviderAdapter
> so that we can reduce lots of code.
> 
> BUG=548254
> 
> Committed: https://crrev.com/a8227af5f6016e10e78b539ffa55aeb634ca7601
> Cr-Commit-Position: refs/heads/master@{#377552}

TBR=tkent@chromium.org,bashi@chromium.org,esprehn@chromium.org,haraken@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548254
==========

to

==========
Revert of Refactoring: Move some classes from content/child to platform
(patchset #17 id:320001 of https://codereview.chromium.org/1660383002/ )

Reason for revert:
This CL makes perf benchmarks fail on several platforms.

The bisect result:
https://chromeperf.appspot.com/group_report?bug_id=589850

Original issue's description:
> Refactoring: Move some classes from content/child to platform
> 
> This CL moves these classes:
> - WebMemoryAllocatorDumpImpl
> - WebMemoryDumpProviderAdapter
> - WebProcessMemoryDumpImpl(Test)
> from content/child to platform. Now that platform can depend on base,
> we don't need adapter classes in Chromium side.
> 
> After this CL, we will be able to reduce glue classes by unifying:
> - WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl
> - WebProcessMemoryDump and WebProcessMemoryDumpImpl
> - WebMemoryDumpProvider and WebMemoryDumpProviderAdapter
> so that we can reduce lots of code.
> 
> BUG=548254
> 
> Committed: https://crrev.com/a8227af5f6016e10e78b539ffa55aeb634ca7601
> Cr-Commit-Position: refs/heads/master@{#377552}

TBR=tkent@chromium.org,bashi@chromium.org,esprehn@chromium.org,haraken@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=548254
==========

[Zhen Wang, 2016-02-25 23:08:38]

Fixed patch failures in
- content/child/blink_platform_impl.h
- content/child/blink_platform_impl.cc
- third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

Removed the following to run trybots
- NOTREECHECKS=true
- NOTRY=true

CQ again ...

[Zhen Wang, 2016-02-25 23:09:08]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-02-25 23:19:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739113002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739113002/280001

[commit-bot: I haz the power, 2016-02-26 00:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 00:13:01]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Zhen Wang, 2016-02-26 00:56:43]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-02-26 01:03:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739113002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739113002/280001

[commit-bot: I haz the power, 2016-02-26 01:10:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 01:10:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Zhen Wang, 2016-02-26 01:41:55]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-02-26 01:42:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739113002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739113002/280001

[commit-bot: I haz the power, 2016-02-26 02:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 02:42:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Primiano Tucci (use gerrit), 2016-02-26 03:27:16]

On 2016/02/26 02:42:46, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Reattempting revert in https://codereview.chromium.org/1741673002/
I think merge resolution went wrong here, given the state of the bots (or some
other change in the middle happened without conflicting in git)

[Zhen Wang, 2016-02-26 16:53:00]

This is not necessary anymore after
https://codereview.chromium.org/1731893004/
See perf-sheriffs@ mail in
https://groups.google.com/a/chromium.org/forum/#!topic/perf-sheriffs/qzBBC3xvQzk

Closing this CL...