Issue 17391016: Avoid relying on monkey-patchable things in String.prototype.split.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17391016: Avoid relying on monkey-patchable things in String.prototype.split. (Closed)

Created:
7 years, 6 months ago by Sven Panne

Modified:
7 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Avoid relying on monkey-patchable things in String.prototype.split. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15206

Patch Set 3 : rebased #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	src/string.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	A +	test/mjsunit/regress/string-split-monkey-patching.js	View	1	1 chunk	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comment. https://codereview.chromium.org/17391016/diff/1/src/string.js File src/string.js (right): https://codereview.chromium.org/17391016/diff/1/src/string.js#newcode666 src/string.js:666: result[result.length] = %_SubString(subject, currentIndex, length); Wouldn't ...

7 years, 6 months ago (2013-06-19 10:30:43 UTC) #2

Sven Panne

7 years, 6 months ago (2013-06-19 12:25:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r15206 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17391016: Avoid relying on monkey-patchable things in String.prototype.split. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed the fix #

Patch Set 3 : rebased #

Messages