Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17391006: cc: Add BeginFrameArgs (Closed)

Created:
7 years, 6 months ago by brianderson
Modified:
7 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, James Su, boliu, joth, ajuma
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: Add BeginFrameArgs In addition to the frame_time, include a deadline and interval with BeginFrame. Values used are placeholders for now, but will be used in the near future. BUG=240945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207166

Patch Set 1 #

Total comments: 1

Patch Set 2 : adjust_deadline_for_parent #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -124 lines) Patch
M cc/cc.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A cc/output/begin_frame_args.h View 1 chunk +49 lines, -0 lines 0 comments Download
A cc/output/begin_frame_args.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M cc/output/output_surface.h View 1 4 chunks +12 lines, -4 lines 0 comments Download
M cc/output/output_surface.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download
M cc/output/output_surface_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/output/output_surface_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M cc/scheduler/frame_rate_controller.h View 5 chunks +6 lines, -5 lines 0 comments Download
M cc/scheduler/frame_rate_controller.cc View 4 chunks +13 lines, -1 line 0 comments Download
M cc/scheduler/frame_rate_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 29 chunks +29 lines, -29 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 17 chunks +19 lines, -19 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/test/fake_output_surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/test/scheduler_test_common.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 6 chunks +21 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 3 chunks +15 lines, -3 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/common/cc_messages.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
brianderson
PTAL. This is a continuation of https://codereview.chromium.org/16863005/
7 years, 6 months ago (2013-06-18 19:14:30 UTC) #1
piman
LGTM https://codereview.chromium.org/17391006/diff/1/cc/output/output_surface.h File cc/output/output_surface.h (right): https://codereview.chromium.org/17391006/diff/1/cc/output/output_surface.h#newcode62 cc/output/output_surface.h:62: has_parent_compositor(true) {} nit: as discussed, maybe rename as ...
7 years, 6 months ago (2013-06-18 19:43:31 UTC) #2
nduca
lgtm
7 years, 6 months ago (2013-06-18 19:51:33 UTC) #3
aelias_OOO_until_Jul13
lgtm
7 years, 6 months ago (2013-06-18 20:20:01 UTC) #4
Cris Neckar
IPC changes lgtm
7 years, 6 months ago (2013-06-18 20:31:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/17391006/8001
7 years, 6 months ago (2013-06-18 20:36:38 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-18 20:57:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/17391006/22001
7 years, 6 months ago (2013-06-18 21:15:29 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 03:54:37 UTC) #9
Message was sent while issue was closed. 
Change committed as 207166

Powered by Google App Engine
This is Rietveld 408576698