Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8245)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 17391005: Remove Instant hooks from SearchProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index ad8c7353d76dcb55cdaf006a792c42b01718535a..af830ff4199c76b21080c50af605098eafdf92ff 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -21,7 +21,6 @@
#include "chrome/browser/autocomplete/extension_app_provider.h"
#include "chrome/browser/autocomplete/history_url_provider.h"
#include "chrome/browser/autocomplete/keyword_provider.h"
-#include "chrome/browser/autocomplete/search_provider.h"
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/command_updater.h"
#include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
@@ -227,25 +226,6 @@ void OmniboxEditModel::SetUserText(const string16& text) {
is_instant_temporary_text_a_search_query_ = false;
}
-void OmniboxEditModel::FinalizeInstantQuery(
- const string16& input_text,
- const InstantSuggestion& suggestion) {
-// Should only get called for the HTML popup.
-#if defined(HTML_INSTANT_EXTENDED_POPUP)
- if (!popup_model()->result().empty()) {
- // When a IME is active and a candidate window is open, we don't show
- // the omnibox popup, though |result()| may be available. Thus we check
- // whether result().empty() or not instead of whether IsOpen() or not.
- // We need the finalization of instant query when result() is available.
- SearchProvider* search_provider =
- autocomplete_controller()->search_provider();
- // There may be no providers during testing; guard against that.
- if (search_provider)
- search_provider->FinalizeInstantQuery(input_text, suggestion);
- }
-#endif
-}
-
void OmniboxEditModel::SetInstantSuggestion(
const InstantSuggestion& suggestion) {
// Should only get called for the HTML popup.
@@ -253,14 +233,11 @@ void OmniboxEditModel::SetInstantSuggestion(
switch (suggestion.behavior) {
case INSTANT_COMPLETE_NOW:
view_->SetInstantSuggestion(string16());
- if (!suggestion.text.empty())
- FinalizeInstantQuery(view_->GetText(), suggestion);
break;
case INSTANT_COMPLETE_NEVER: {
DCHECK_EQ(INSTANT_SUGGESTION_SEARCH, suggestion.type);
view_->SetInstantSuggestion(suggestion.text);
- autocomplete_controller()->search_provider()->ClearInstantSuggestion();
break;
}
@@ -343,9 +320,6 @@ void OmniboxEditModel::OnChanged() {
if (!performed_instant) {
// Hide any suggestions we might be showing.
view_->SetInstantSuggestion(string16());
-
- // No need to wait any longer for Instant.
- FinalizeInstantQuery(string16(), InstantSuggestion());
}
switch (recommended_action) {

Powered by Google App Engine
This is Rietveld 408576698