Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1739063002: Fix oval rendering in vulkan (Closed)

Created:
4 years, 10 months ago by egdaniel
Modified:
4 years, 10 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@uboFormat
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
egdaniel
https://codereview.chromium.org/1739063002/diff/1/src/gpu/vk/GrVkCaps.cpp File src/gpu/vk/GrVkCaps.cpp (right): https://codereview.chromium.org/1739063002/diff/1/src/gpu/vk/GrVkCaps.cpp#newcode124 src/gpu/vk/GrVkCaps.cpp:124: glslCaps->fShaderDerivativeSupport = true; This should always be supported and ...
4 years, 10 months ago (2016-02-25 21:07:23 UTC) #3
jvanverth1
lgtm
4 years, 10 months ago (2016-02-25 21:09:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739063002/1
4 years, 10 months ago (2016-02-26 16:21:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 16:32:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/67acb83ce96149edf2c5dd56b0d08ffa8011dae9

Powered by Google App Engine
This is Rietveld 408576698