Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1739023005: Don't compile in root certs when SSL is disabled in GN build. (Closed)

Created:
4 years, 9 months ago by zra
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't compile in root certs when SSL is disabled in GN build. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/e03a9d54c7b3bc913a5f2f10825e161f9e1e7988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/bin/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 9 months ago (2016-02-26 18:35:09 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-02-26 18:36:41 UTC) #3
zra
4 years, 9 months ago (2016-02-26 18:37:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e03a9d54c7b3bc913a5f2f10825e161f9e1e7988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698