Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1739023003: Update status for VM crash on address sanitizer (asan) bot. (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for VM crash on address sanitizer (asan) bot. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/47b2253866947fe556e1503d974a8adc4a6c33ae

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
I think this is not a bug - this is exactly what should be happening ...
4 years, 10 months ago (2016-02-25 22:16:30 UTC) #2
Florian Schneider
https://codereview.chromium.org/1739023003/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/1739023003/diff/1/runtime/tests/vm/vm.status#newcode82 runtime/tests/vm/vm.status:82: cc/CodeImmutability: Fail,OK # Address Sanitizer turns a crash into ...
4 years, 10 months ago (2016-02-25 22:35:37 UTC) #3
Bill Hesse
It probably was green, because the bots were broken, stuck green for two weeks. The ...
4 years, 10 months ago (2016-02-25 22:44:22 UTC) #4
Florian Schneider
Ok, I see. Lgtm.
4 years, 10 months ago (2016-02-25 23:40:51 UTC) #5
Bill Hesse
4 years, 10 months ago (2016-02-25 23:53:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47b2253866947fe556e1503d974a8adc4a6c33ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698