Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 17390019: Add Android device testers for WebRTC. (Closed)

Created:
7 years, 6 months ago by kjellander_chromium
Modified:
7 years, 3 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org, hellner1
Visibility:
Public.

Description

Add Android device testers for WebRTC. Add two new testers that runs WebRTC tests on Android devices. WebRTC tests are reusing a lot of the Chromium toolchain, which is why these bots have the somewhat complicated setup of using a Chromium checkout and then checkout ToT WebRTC into third_party/webrtc (using the webrtc.DEPS solution). This CL depends on the following CLs: * https://codereview.chromium.org/23004021/ - Add WebRTC .isolate files to setup.py * https://codereview.chromium.org/23075028/ - Resources download * http://review.webrtc.org/2107004/ - Android config for WebRTC .isolate files. TEST=successful builds with local master and slave with Nexus 7 device. BUG=webrtc:1882 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=220061

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Total comments: 10

Patch Set 4 : Changes to address review comments #

Patch Set 5 : Remove a space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -15 lines) Patch
M masters/master.client.webrtc/master.cfg View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A masters/master.client.webrtc/master_android_cfg.py View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download
M masters/master.client.webrtc/master_linux_cfg.py View 1 2 3 chunks +0 lines, -14 lines 0 comments Download
M masters/master.client.webrtc/slaves.cfg View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kjellander_chromium
This CL depends on https://codereview.chromium.org/17466002/ before getting landed.
7 years, 6 months ago (2013-06-19 14:15:43 UTC) #1
kjellander_chromium
Actually, you may want to wait reviewing this CL until https://codereview.chromium.org/16959006/ is reviewed and landed. ...
7 years, 6 months ago (2013-06-19 14:21:15 UTC) #2
kjellander_chromium
On 2013/06/19 14:21:15, Henrik Kjellander wrote: > Actually, you may want to wait reviewing this ...
7 years, 6 months ago (2013-06-25 09:05:15 UTC) #3
kjellander_chromium
On 2013/06/25 09:05:15, Henrik Kjellander wrote: > On 2013/06/19 14:21:15, Henrik Kjellander wrote: > > ...
7 years, 3 months ago (2013-08-26 20:04:13 UTC) #4
kjellander_chromium
I realized that https://codereview.chromium.org/23075028/ will need to be committed to, before this works.
7 years, 3 months ago (2013-08-27 06:03:58 UTC) #5
Isaac (away)
LGTM w/ nits. https://codereview.chromium.org/17390019/diff/27001/masters/master.client.webrtc/master_android_cfg.py File masters/master.client.webrtc/master_android_cfg.py (right): https://codereview.chromium.org/17390019/diff/27001/masters/master.client.webrtc/master_android_cfg.py#newcode45 masters/master.client.webrtc/master_android_cfg.py:45: 'gclient_env': builder_gclient_env, I don't think this ...
7 years, 3 months ago (2013-08-27 06:15:27 UTC) #6
kjellander_chromium
https://codereview.chromium.org/17390019/diff/27001/masters/master.client.webrtc/master_android_cfg.py File masters/master.client.webrtc/master_android_cfg.py (right): https://codereview.chromium.org/17390019/diff/27001/masters/master.client.webrtc/master_android_cfg.py#newcode45 masters/master.client.webrtc/master_android_cfg.py:45: 'gclient_env': builder_gclient_env, On 2013/08/27 06:15:27, Isaac wrote: > I ...
7 years, 3 months ago (2013-08-27 08:14:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/17390019/42001
7 years, 3 months ago (2013-08-28 18:36:28 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-08-28 18:37:17 UTC) #9
Message was sent while issue was closed.
Change committed as 220061

Powered by Google App Engine
This is Rietveld 408576698