chrome/browser/translate/translate_manager_browsertest.cc - Issue 17390018: Refactoring: Create TranslateScript from TranslateManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 17390018: Refactoring: Create TranslateScript from TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactoring-translate-url-fetcher

Patch Set: (Non trivial rebasing) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/translate_manager.cc ('K') | « chrome/browser/translate/translate_manager.cc ('k') | chrome/browser/translate/translate_script.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_browsertest.cc

diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc

index 832a66f6dff7c02f551e25e75592fc2644388bdf..db1b543c5092b5e24eef76b48da7e73c81df9317 100644

--- a/chrome/browser/translate/translate_manager_browsertest.cc

+++ b/chrome/browser/translate/translate_manager_browsertest.cc

@@ -49,6 +49,7 @@

#include "grit/generated_resources.h"

#include "ipc/ipc_test_sink.h"

#include "net/url_request/test_url_fetcher_factory.h"

+#include "net/url_request/url_fetcher_delegate.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "third_party/WebKit/public/web/WebContextMenuData.h"

#include "third_party/WebKit/public/web/WebKit.h"

@@ -180,7 +181,7 @@ class TranslateManagerBrowserTest : public ChromeRenderViewHostTestHarness,

}

void ExpireTranslateScriptImmediately() {

- TranslateManager::GetInstance()->set_translate_script_expiration_delay(0);

+ TranslateManager::GetInstance()->SetTranslateScriptExpirationDelay(0);

}

// If there is 1 infobar and it is a translate infobar, deny translation and

@@ -235,7 +236,7 @@ class TranslateManagerBrowserTest : public ChromeRenderViewHostTestHarness,

// case it was zeroed in a previous test).

TranslateManager::GetInstance()->ClearTranslateScript();

TranslateManager::GetInstance()->

- set_translate_script_expiration_delay(60 * 60 * 1000);

+ SetTranslateScriptExpirationDelay(60 * 60 * 1000);

TranslateManager::GetInstance()->set_translate_max_reload_attemps(0);

ChromeRenderViewHostTestHarness::SetUp();

« chrome/browser/translate/translate_manager.cc ('K') | « chrome/browser/translate/translate_manager.cc ('k') | chrome/browser/translate/translate_script.h » ('j') | no next file with comments »