CSS Background Blending doesn't work for svg layers.

CSS Background Blending doesn't work for svg layers.

The blending operation won't be performed for any of the background layers
located under an svg background. The fix consisted of adding the blend mode
operator when drawing the svg in SVGImage.

BUG=251240
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152877

[mitica, 2013-06-18 14:07:02]

Hi Stephen, can you please also review this change? Thanks!

[Stephen Chennney, 2013-06-18 14:43:14]

Mostly good, with a nit about the tests.

To land this you will probably have to add [ Missing ] expectations for the
tests to TestExpectations, and then add the baselines after the patch has
landed. The commit queue cannot handle png files.

https://codereview.chromium.org/17390003/diff/1/LayoutTests/css3/compositing/...
File LayoutTests/css3/compositing/resources/red-circle.svg (right):

https://codereview.chromium.org/17390003/diff/1/LayoutTests/css3/compositing/...
LayoutTests/css3/compositing/resources/red-circle.svg:2: <circle cx="50" cy="50"
r="40" stroke="black" stroke-width="2" fill="red">
I would prefer it if this were blue, presuming that does not reduce the test's
usefulness. Red indicates error and this is not erroneous, but you use green
elsewhere.

[mitica, 2013-06-19 12:27:38]

On 2013/06/18 14:43:14, Stephen Chenney wrote:
> Mostly good, with a nit about the tests.
> 
> To land this you will probably have to add [ Missing ] expectations for the
> tests to TestExpectations, and then add the baselines after the patch has
> landed. The commit queue cannot handle png files.
> 
>
https://codereview.chromium.org/17390003/diff/1/LayoutTests/css3/compositing/...
> File LayoutTests/css3/compositing/resources/red-circle.svg (right):
> 
>
https://codereview.chromium.org/17390003/diff/1/LayoutTests/css3/compositing/...
> LayoutTests/css3/compositing/resources/red-circle.svg:2: <circle cx="50"
cy="50"
> r="40" stroke="black" stroke-width="2" fill="red">
> I would prefer it if this were blue, presuming that does not reduce the test's
> usefulness. Red indicates error and this is not erroneous, but you use green
> elsewhere.

Agreed about the color, I've updated it in the last patchset, could you please
have another look?

[Stephen Chennney, 2013-06-20 16:49:39]

lgtm

[commit-bot: I haz the power, 2013-06-21 09:04:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitica@adobe.com/17390003/11001

[commit-bot: I haz the power, 2013-06-21 12:16:01]

Change committed as 152877