Source/modules/mediastream/NavigatorMediaStream.cpp - Issue 173893009: MediaStream API: Update getUserMedia to match the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/NavigatorMediaStream.cpp

Issue 173893009: MediaStream API: Update getUserMedia to match the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/mediastream/script-tests/argument-types.js ('k') | Source/modules/mediastream/NavigatorMediaStream.idl » ('j') | Source/modules/mediastream/UserMediaRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediastream/NavigatorMediaStream.cpp

diff --git a/Source/modules/mediastream/NavigatorMediaStream.cpp b/Source/modules/mediastream/NavigatorMediaStream.cpp

index 77870d6caa2166267c172e7e1c09496a6c104a86..78175436a2189154b3de47df7f6c969a2667e0a0 100644

--- a/Source/modules/mediastream/NavigatorMediaStream.cpp

+++ b/Source/modules/mediastream/NavigatorMediaStream.cpp

@@ -60,8 +60,7 @@ void NavigatorMediaStream::webkitGetUserMedia(Navigator& navigator, const Dictio

RefPtr<UserMediaRequest> request = UserMediaRequest::create(navigator.frame()->document(), userMedia, options, successCallback, errorCallback, exceptionState);

if (!request) {

- if (!exceptionState.hadException())

- exceptionState.throwDOMException(NotSupportedError, "Failed to request user media.");

+ ASSERT(exceptionState.hadException());

return;

}