Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 173893002: use colortype instead of config (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 10 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

use colortype instead of config patch from issue 172063004 BUG=skia: R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=13520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -99 lines) Patch
M include/core/SkImageInfo.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkBitmapFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmap_scroll.cpp View 2 chunks +2 lines, -20 lines 0 comments Download
M src/core/SkBlitter.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkDraw.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/core/SkScalerContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkSpriteBlitter_ARGB32.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
6 years, 10 months ago (2014-02-20 15:36:42 UTC) #1
scroggo
On 2014/02/20 15:36:42, reed1 wrote: LGTM For the future, when patching from another issue and ...
6 years, 10 months ago (2014-02-20 15:46:51 UTC) #2
reed1
On 2014/02/20 15:46:51, scroggo wrote: > On 2014/02/20 15:36:42, reed1 wrote: > > LGTM > ...
6 years, 10 months ago (2014-02-20 16:55:06 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-20 16:56:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/173893002/1
6 years, 10 months ago (2014-02-20 16:56:20 UTC) #5
reed1
On 2014/02/20 16:55:06, reed1 wrote: > On 2014/02/20 15:46:51, scroggo wrote: > > On 2014/02/20 ...
6 years, 10 months ago (2014-02-20 16:59:48 UTC) #6
reed1
The CQ bit was unchecked by reed@google.com
6 years, 10 months ago (2014-02-20 20:54:19 UTC) #7
reed1
6 years, 10 months ago (2014-02-20 20:55:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r13520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698