Enable RAW codec for Windows

src/codec/SkRawCodec.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
+#include "SkAtomics.h"
 #include "SkCodec.h"
 #include "SkCodecPriv.h"
 #include "SkColorPriv.h"
 #include "SkData.h"
 #include "SkJpegCodec.h"
 #include "SkRawCodec.h"
 #include "SkRefCnt.h"
 #include "SkStream.h"
 #include "SkStreamPriv.h"
 #include "SkSwizzler.h"
 #include "SkTaskGroup.h"
 #include "SkTemplates.h"
 #include "SkTypes.h"
 
 #include "dng_area_task.h"
 #include "dng_color_space.h"
+#include "dng_errors.h"
 #include "dng_exceptions.h"
 #include "dng_host.h"
 #include "dng_info.h"
 #include "dng_memory.h"
 #include "dng_render.h"
 #include "dng_stream.h"
 
 #include "src/piex.h"
 
 #include <cmath>  // for std::round,floor,ceil
@@ skipping 64 matching lines @@
         // sub-tasks depending on the architecture.
         const int maxTasks = static_cast<int>(task.MaxThreads());
 
         SkTaskGroup taskGroup;
 
         // tileSize is typically 256x256
         const dng_point tileSize(task.FindTileSize(area));
         const std::vector<dng_rect> taskAreas = compute_task_areas(maxTasks, area, tileSize);
         const int numTasks = static_cast<int>(taskAreas.size());
 
+        SkAtomic<dng_error_code> dngErrorCode(dng_error_none);

[mtklein, 2016/02/26 13:29:11]

Generally I'd prefer that we use a mutex until it proves to be a performance
problem.
I can't imagine it is here, given that you'd only be locking the mutex on error.

This would also allow you to gather all the errors, or perhaps even store the
dng_exception rather than just its error code?
(I don't know if that matters.)

SkMutex mutex;
SkTArray<dng_exception> exceptions;

taskGroup.add([&mutex, &exceptions, ... ]) {
  try { ... }

  catch (dng_exception& except) {
     SkAutoMutexAcquire lock(mutex);
     exceptions.push_back(except);
  }
  ...
}

taskGroup.Wait();
task.Finish(numTasks)

if (exceptions.count()) {
   ...
}

[yujieqin, 2016/02/26 14:02:37]

Thanks for the tips. 

I will store all the exceptions, but only re-throw the first catched for now.

         task.Start(numTasks, tileSize, &Allocator(), Sniffer());
         for (int taskIndex = 0; taskIndex < numTasks; ++taskIndex) {
-            taskGroup.add([&task, this, taskIndex, taskAreas, tileSize] {
-                task.ProcessOnThread(taskIndex, taskAreas[taskIndex], tileSize, this->Sniffer());
+            taskGroup.add([&task, &dngErrorCode, this, taskIndex, taskAreas, tileSize] {
+                try {
+                    task.ProcessOnThread(taskIndex, taskAreas[taskIndex], tileSize, this->Sniffer());
+                } catch (dng_exception& except) {
+                    dngErrorCode = except.ErrorCode(); 
+                } catch (...) {
+                    dngErrorCode = dng_error_unknown;
+                }
             });
         }
 
         taskGroup.wait();
         task.Finish(numTasks);
+
+        if (dngErrorCode != dng_error_none) {
+            Throw_dng_error(dngErrorCode, nullptr, nullptr);
+        }
     }
 
     uint32 PerformAreaTaskThreads() override {
         // FIXME: Need to get the real amount of available threads used in the SkTaskGroup.
         return kMaxMPThreads;
     }
 
 private:
     typedef dng_host INHERITED;
 };
@@ skipping 294 matching lines @@
      *   requested size:         1600 x 1200
      *   returned size could be: 2000 x 1500
      */
     dng_image* render(int width, int height) {
         if (!fHost || !fInfo || !fNegative || !fDngStream) {
             if (!this->readDng()) {
                 return nullptr;
             }
         }
 
-        // render() takes ownership of fHost, fInfo, fNegative and fDngStream when available.
-        SkAutoTDelete<dng_host> host(fHost.release());
-        SkAutoTDelete<dng_info> info(fInfo.release());
-        SkAutoTDelete<dng_negative> negative(fNegative.release());
-        SkAutoTDelete<dng_stream> dngStream(fDngStream.release());
-
         // DNG SDK preserves the aspect ratio, so it only needs to know the longer dimension.
         const int preferredSize = SkTMax(width, height);
         try {
+            // render() takes ownership of fHost, fInfo, fNegative and fDngStream when available.
+            SkAutoTDelete<dng_host> host(fHost.release());
+            SkAutoTDelete<dng_info> info(fInfo.release());
+            SkAutoTDelete<dng_negative> negative(fNegative.release());
+            SkAutoTDelete<dng_stream> dngStream(fDngStream.release());
+
             host->SetPreferredSize(preferredSize);
             host->ValidateSizes();
 
             negative->ReadStage1Image(*host, *dngStream, *info);
 
             if (info->fMaskIndex != -1) {
                 negative->ReadTransparencyMask(*host, *dngStream, *info);
             }
 
             negative->ValidateRawImageDigest(*host);
@@ skipping 49 matching lines @@
         {
             dng_point cfaPatternSize(imageData.cfa_pattern_dim[1], imageData.cfa_pattern_dim[0]);
             this->init(static_cast<int>(imageData.full_width),
                        static_cast<int>(imageData.full_height), cfaPatternSize);
             return true;
         }
         return false;
     }
 
     bool readDng() {
-        // Due to the limit of DNG SDK, we need to reset host and info.
-        fHost.reset(new SkDngHost(&fAllocator));
-        fInfo.reset(new dng_info);
-        fDngStream.reset(new SkDngStream(fStream));
         try {
+            // Due to the limit of DNG SDK, we need to reset host and info.
+            fHost.reset(new SkDngHost(&fAllocator));
+            fInfo.reset(new dng_info);
+            fDngStream.reset(new SkDngStream(fStream));
+
             fHost->ValidateSizes();
             fInfo->Parse(*fHost, *fDngStream);
             fInfo->PostParse(*fHost);
             if (!fInfo->IsValidDNG()) {
                 return false;
             }
 
             fNegative.reset(fHost->Make_dng_negative());
             fNegative->Parse(*fHost, *fDngStream, *fInfo);
             fNegative->PostParse(*fHost, *fDngStream, *fInfo);
@@ skipping 158 matching lines @@
     SkISize sizeFloor = this->onGetScaledDimensions(1.f / std::floor(fullShortEdge / shortEdge));
     SkISize sizeCeil = this->onGetScaledDimensions(1.f / std::ceil(fullShortEdge / shortEdge));
     return sizeFloor == dim || sizeCeil == dim;
 }
 
 SkRawCodec::~SkRawCodec() {}
 
 SkRawCodec::SkRawCodec(SkDngImage* dngImage)
     : INHERITED(dngImage->getImageInfo(), nullptr)
     , fDngImage(dngImage) {}